Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 7739 #270

Merged
merged 2 commits into from
Oct 25, 2024
Merged

chore: remove 7739 #270

merged 2 commits into from
Oct 25, 2024

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented Oct 23, 2024

No description provided.

Copy link

octane-security-app bot commented Oct 23, 2024

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • SemiModularAccountBase.sol: The smart contract modifications introduced replay-safe hash generation for improved security against replay attacks and removed the ERC7739 wrapper dependency.
  • SingleSignerValidationModule.sol: The smart contract now integrates ReplaySafeWrapper for enhanced security through replay protection in signature validation.
  • AccountTestBase.sol: Simplified hash calculation and signature packing in deferred validation for improved efficiency.
  • ModuleSignatureUtils.sol: The updated smart contract improves replay protection and simplifies signature handling by removing ERC7739 functionality and adding new domain separator logic.

🔗 Commit Hash: 1b45ecb

Copy link

Contract sizes:

 | Contract                      | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
 |-------------------------------|------------------|-------------------|--------------------|---------------------|
 | AccountFactory                |            4,814 |             5,239 |             19,762 |              43,913 |
 | Address                       |               17 |                46 |             24,559 |              49,106 |
 | AllowlistModule               |            9,903 |             9,930 |             14,673 |              39,222 |
 | Base64                        |               17 |                46 |             24,559 |              49,106 |
 | ECDSA                         |               17 |                46 |             24,559 |              49,106 |
 | ERC165Checker                 |               17 |                46 |             24,559 |              49,106 |
 | ERC1967Utils                  |               17 |                46 |             24,559 |              49,106 |
 | ExecutionInstallDelegate      |            5,694 |             5,740 |             18,882 |              43,412 |
 | FCL_Elliptic_ZZ               |               17 |                46 |             24,559 |              49,106 |
 | FCL_ecdsa                     |               17 |                46 |             24,559 |              49,106 |
 | Math                          |               17 |                46 |             24,559 |              49,106 |
 | MessageHashUtils              |               17 |                46 |             24,559 |              49,106 |
 | ModularAccount                |           21,971 |            28,654 |              2,605 |              20,498 |
 | NativeFunctionDelegate        |              434 |               461 |             24,142 |              48,691 |
 | NativeTokenLimitModule        |            4,258 |             4,285 |             20,318 |              44,867 |
 | PaymasterGuardModule          |            1,797 |             1,824 |             22,779 |              47,328 |
 | SafeERC20                     |               17 |                46 |             24,559 |              49,106 |
-| SemiModularAccountBytecode    |           24,045 |            30,728 |                531 |              18,424 |
-| SemiModularAccountStorageOnly |           24,539 |            31,222 |                 37 |              17,930 |
+| SemiModularAccountBytecode    |           23,273 |            29,956 |              1,303 |              19,196 |
+| SemiModularAccountStorageOnly |           23,767 |            30,450 |                809 |              18,702 |
 | SignatureChecker              |               17 |                46 |             24,559 |              49,106 |
 | SignedMath                    |               17 |                46 |             24,559 |              49,106 |
-| SingleSignerValidationModule  |            4,300 |             4,327 |             20,276 |              44,825 |
+| SingleSignerValidationModule  |            3,646 |             3,673 |             20,930 |              45,479 |
 | StorageSlot                   |               17 |                46 |             24,559 |              49,106 |
 | Strings                       |               17 |                46 |             24,559 |              49,106 |
 | TimeRangeModule               |            2,000 |             2,027 |             22,576 |              47,125 |
 | WebAuthn                      |               17 |                46 |             24,559 |              49,106 |
 | WebAuthnValidationModule      |            7,854 |             7,881 |             16,722 |              41,271 |

Code coverage:

File % Lines % Statements % Branches % Funcs
src/account/AccountBase.sol 100.00% (8/8) 100.00% (7/7) 100.00% (2/2) 100.00% (4/4)
src/account/AccountStorageInitializable.sol 100.00% (19/19) 100.00% (26/26) 100.00% (5/5) 100.00% (2/2)
src/account/ModularAccount.sol 100.00% (2/2) 100.00% (2/2) 100.00% (0/0) 100.00% (3/3)
src/account/ModularAccountBase.sol 98.99% (294/297) 96.29% (363/377) 77.59% (45/58) 100.00% (36/36)
src/account/ModularAccountView.sol 100.00% (24/24) 100.00% (28/28) 100.00% (2/2) 100.00% (4/4)
src/account/ModuleManagerInternals.sol 95.08% (58/61) 96.20% (76/79) 62.50% (5/8) 100.00% (3/3)
src/account/SemiModularAccountBase.sol 88.71% (55/62) 92.13% (82/89) 66.67% (10/15) 100.00% (16/16)
src/account/SemiModularAccountBytecode.sol 100.00% (6/6) 100.00% (7/7) 100.00% (1/1) 66.67% (2/3)
src/account/SemiModularAccountStorageOnly.sol 80.00% (4/5) 83.33% (5/6) 100.00% (0/0) 66.67% (2/3)
src/account/TokenReceiver.sol 33.33% (1/3) 33.33% (1/3) 100.00% (0/0) 33.33% (1/3)
src/factory/AccountFactory.sol 70.59% (24/34) 76.09% (35/46) 40.00% (2/5) 58.33% (7/12)
src/helpers/ExecutionInstallDelegate.sol 92.59% (50/54) 92.96% (66/71) 40.00% (2/5) 100.00% (7/7)
src/helpers/NativeFunctionDelegate.sol 100.00% (16/16) 100.00% (30/30) 100.00% (0/0) 100.00% (1/1)
src/libraries/ExecutionLib.sol 98.92% (274/277) 98.15% (266/271) 84.85% (28/33) 100.00% (24/24)
src/libraries/KnownSelectorsLib.sol 100.00% (15/15) 100.00% (32/32) 100.00% (0/0) 100.00% (2/2)
src/libraries/LinkedListSetLib.sol 94.00% (47/50) 96.25% (77/80) 66.67% (4/6) 100.00% (8/8)
src/libraries/MemManagementLib.sol 100.00% (54/54) 100.00% (70/70) 100.00% (0/0) 100.00% (12/12)
src/libraries/ModuleInstallCommonsLib.sol 57.14% (8/14) 42.11% (8/19) 75.00% (3/4) 100.00% (3/3)
src/modules/ModuleBase.sol 100.00% (13/13) 94.12% (16/17) 100.00% (2/2) 100.00% (3/3)
src/modules/permissions/AllowlistModule.sol 86.05% (74/86) 85.71% (96/112) 78.26% (18/23) 50.00% (9/18)
src/modules/permissions/NativeTokenLimitModule.sol 92.31% (36/39) 92.86% (52/56) 100.00% (9/9) 63.64% (7/11)
src/modules/permissions/PaymasterGuardModule.sol 90.00% (9/10) 86.67% (13/15) 100.00% (2/2) 71.43% (5/7)
src/modules/permissions/TimeRangeModule.sol 83.33% (10/12) 80.00% (16/20) 100.00% (1/1) 75.00% (6/8)
src/modules/validation/SingleSignerValidationModule.sol 92.00% (23/25) 81.58% (31/38) 62.50% (5/8) 90.00% (9/10)
src/modules/validation/WebAuthnValidationModule.sol 61.11% (11/18) 66.67% (18/27) 100.00% (3/3) 60.00% (6/10)
Total 94.27% (1135/1204) 93.13% (1423/1528) 77.60% (149/192) 85.45% (182/213)

Copy link

octane-security-app bot commented Oct 23, 2024

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉


🔗 Commit Hash: 1b45ecb

@jaypaik jaypaik requested a review from adamegyed October 24, 2024 20:14
@howydev howydev merged commit 6f290f2 into develop Oct 25, 2024
6 checks passed
@howydev howydev deleted the howy/remove-7739 branch October 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants