fix: [CL-007] [QS-13] add invalidateDeferredValidationInstallNonce to native selectors check #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 07e5c19 |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 4,814 | 5,239 | 19,762 | 43,913 |
| AllowlistModule | 9,553 | 9,580 | 15,023 | 39,572 |
| ExecutionInstallDelegate | 5,714 | 5,760 | 18,862 | 43,392 |
-| ModularAccount | 21,973 | 28,676 | 2,603 | 20,476 |
-| NativeFunctionDelegate | 434 | 461 | 24,142 | 48,691 |
+| ModularAccount | 21,973 | 28,802 | 2,603 | 20,350 |
+| NativeFunctionDelegate | 560 | 587 | 24,016 | 48,565 |
| NativeTokenLimitModule | 4,449 | 4,476 | 20,127 | 44,676 |
| PaymasterGuardModule | 1,845 | 1,872 | 22,731 | 47,280 |
-| SemiModularAccountBytecode | 23,275 | 29,978 | 1,301 | 19,174 |
-| SemiModularAccountStorageOnly | 23,769 | 30,472 | 807 | 18,680 |
+| SemiModularAccountBytecode | 23,275 | 30,104 | 1,301 | 19,048 |
+| SemiModularAccountStorageOnly | 23,769 | 30,598 | 807 | 18,554 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,000 | 2,027 | 22,576 | 47,125 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 |Code coverage:
|
Overview
Detailed findings
|
adamegyed
reviewed
Nov 11, 2024
| @@ -36,6 +36,7 @@ contract NativeFunctionDelegate { | |||
| || selector == uint32(IModularAccountView.getExecutionData.selector) | |||
| || selector == uint32(IModularAccountView.getValidationData.selector) | |||
| // check against ModularAccount methods | |||
| || selector == uint32(ModularAccountBase.performCreate.selector); | |||
| || selector == uint32(ModularAccountBase.performCreate.selector) | |||
| || selector == uint32(ModularAccountBase.invalidateDeferredValidationInstallNonce.selector); | |||
There was a problem hiding this comment.
Do we also want to add isValidSignature, executeUserOp, and the receiver functions (IERC721Receiver.onERC721Received.selector, IERC1155Receiver.onERC1155Received.selector, IERC1155Receiver.onERC1155BatchReceived.selector) to this?
There was a problem hiding this comment.
Went ahead and did this, also refactored to no longer import IModularAccount to make one clean block of function selectors which are all from ModularAccountBase. Lmk what you think!
Zer0dot
force-pushed
the
howy/fix-cl-7
branch
from
291a22b to
07e5c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.