-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Quantstamp-ALC-14] fix execution data view for native functions #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew Contracts
Updated Contracts
🔗 Commit Hash: 927e9f2 |
fangting-alchemy
force-pushed
the
alc14
branch
from
November 15, 2024 00:55
5ea2223
to
6fa612a
Compare
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 5,921 | 6,386 | 18,655 | 42,766 |
| AllowlistModule | 9,553 | 9,580 | 15,023 | 39,572 |
| ExecutionInstallDelegate | 5,714 | 5,760 | 18,862 | 43,392 |
-| ModularAccount | 22,254 | 29,083 | 2,322 | 20,069 |
+| ModularAccount | 22,413 | 29,242 | 2,163 | 19,910 |
| NativeFunctionDelegate | 560 | 587 | 24,016 | 48,565 |
| NativeTokenLimitModule | 4,449 | 4,476 | 20,127 | 44,676 |
| PaymasterGuardModule | 1,845 | 1,872 | 22,731 | 47,280 |
-| SemiModularAccount7702 | 23,157 | 29,979 | 1,419 | 19,173 |
-| SemiModularAccountBytecode | 23,639 | 30,468 | 937 | 18,684 |
-| SemiModularAccountStorageOnly | 24,133 | 30,962 | 443 | 18,190 |
+| SemiModularAccount7702 | 23,315 | 30,137 | 1,261 | 19,015 |
+| SemiModularAccountBytecode | 23,797 | 30,626 | 779 | 18,526 |
+| SemiModularAccountStorageOnly | 24,291 | 31,120 | 285 | 18,032 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,003 | 2,030 | 22,573 | 47,122 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 | Code coverage:
|
Overview
Detailed findings
|
fangting-alchemy
force-pushed
the
alc14
branch
from
November 15, 2024 01:12
3c1fdba
to
eb3c4e5
Compare
Zer0dot
reviewed
Nov 15, 2024
Zer0dot
approved these changes
Nov 15, 2024
fangting-alchemy
force-pushed
the
alc14
branch
from
November 15, 2024 22:51
eb3c4e5
to
927e9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Execution data view method is not returning the correct fields for native functions.
Solution
Return correct fields for the following two types of native functions. Needed to create an interface to avoid circular dependency. It also helps the MA readability now that all external funcs have interfaces.
Also refactored
NativeFunctionDelegate
to import interfaces when available.