Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ALCHEMY-010] extraneous event fixes #295

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Nov 21, 2024

Remove events that are not used.

Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • AccountStorageInitializable.sol: The "NotInitializing" error was removed from the contract's functionality.
  • SemiModularAccountBase.sol: The "InitializerDisabled" error was removed from the smart contract.

🔗 Commit Hash: 60987e5

Copy link
Collaborator Author

jaypaik commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jaypaik jaypaik marked this pull request as ready for review November 21, 2024 05:31
@jaypaik jaypaik requested a review from a team November 21, 2024 05:32
Copy link

Contract sizes:

| Contract                      | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory                |            5,921 |             6,386 |             18,655 |              42,766 |
| AllowlistModule               |            9,553 |             9,580 |             15,023 |              39,572 |
| ExecutionInstallDelegate      |            5,714 |             5,760 |             18,862 |              43,392 |
| ModularAccount                |           22,413 |            29,242 |              2,163 |              19,910 |
| NativeFunctionDelegate        |              560 |               587 |             24,016 |              48,565 |
| NativeTokenLimitModule        |            4,498 |             4,525 |             20,078 |              44,627 |
| PaymasterGuardModule          |            1,845 |             1,872 |             22,731 |              47,280 |
| SemiModularAccount7702        |           23,315 |            30,137 |              1,261 |              19,015 |
| SemiModularAccountBytecode    |           23,797 |            30,626 |                779 |              18,526 |
| SemiModularAccountStorageOnly |           24,291 |            31,120 |                285 |              18,032 |
| SingleSignerValidationModule  |            3,646 |             3,673 |             20,930 |              45,479 |
| TimeRangeModule               |            2,003 |             2,030 |             22,573 |              47,122 |
| WebAuthnValidationModule      |            7,854 |             7,881 |             16,722 |              41,271 |

Code coverage:

File % Lines % Statements % Branches % Funcs
src/account/AccountBase.sol 100.00% (8/8) 100.00% (7/7) 100.00% (2/2) 100.00% (4/4)
src/account/AccountStorageInitializable.sol 100.00% (19/19) 100.00% (26/26) 100.00% (5/5) 100.00% (2/2)
src/account/ModularAccount.sol 100.00% (2/2) 100.00% (2/2) 100.00% (0/0) 100.00% (2/2)
src/account/ModularAccountBase.sol 99.02% (302/305) 96.30% (364/378) 78.33% (47/60) 97.30% (36/37)
src/account/ModularAccountView.sol 95.00% (38/40) 96.30% (52/54) 80.00% (4/5) 100.00% (5/5)
src/account/ModuleManagerInternals.sol 95.08% (58/61) 96.20% (76/79) 62.50% (5/8) 100.00% (3/3)
src/account/SemiModularAccount7702.sol 0.00% (0/6) 0.00% (0/6) 0.00% (0/1) 0.00% (0/3)
src/account/SemiModularAccountBase.sol 89.06% (57/64) 92.31% (84/91) 68.75% (11/16) 100.00% (15/15)
src/account/SemiModularAccountBytecode.sol 100.00% (6/6) 100.00% (7/7) 100.00% (1/1) 100.00% (2/2)
src/account/SemiModularAccountStorageOnly.sol 80.00% (4/5) 83.33% (5/6) 100.00% (0/0) 50.00% (1/2)
src/account/TokenReceiver.sol 33.33% (1/3) 33.33% (1/3) 100.00% (0/0) 33.33% (1/3)
src/factory/AccountFactory.sol 86.67% (39/45) 88.52% (54/61) 50.00% (3/6) 66.67% (10/15)
src/helpers/ExecutionInstallDelegate.sol 92.59% (50/54) 92.96% (66/71) 40.00% (2/5) 100.00% (7/7)
src/helpers/NativeFunctionDelegate.sol 100.00% (22/22) 100.00% (42/42) 100.00% (0/0) 100.00% (1/1)
src/libraries/ExecutionLib.sol 99.64% (276/277) 98.89% (268/271) 90.91% (30/33) 100.00% (24/24)
src/libraries/KnownSelectorsLib.sol 100.00% (16/16) 100.00% (34/34) 100.00% (0/0) 100.00% (2/2)
src/libraries/LinkedListSetLib.sol 94.00% (47/50) 96.25% (77/80) 66.67% (4/6) 100.00% (8/8)
src/libraries/MemManagementLib.sol 100.00% (54/54) 100.00% (70/70) 100.00% (0/0) 100.00% (12/12)
src/libraries/ModuleInstallCommonsLib.sol 57.14% (8/14) 42.11% (8/19) 75.00% (3/4) 100.00% (3/3)
src/modules/ModuleBase.sol 100.00% (13/13) 94.12% (16/17) 100.00% (2/2) 100.00% (3/3)
src/modules/permissions/AllowlistModule.sol 86.05% (74/86) 85.71% (96/112) 78.26% (18/23) 50.00% (9/18)
src/modules/permissions/NativeTokenLimitModule.sol 90.91% (40/44) 91.80% (56/61) 100.00% (13/13) 66.67% (8/12)
src/modules/permissions/PaymasterGuardModule.sol 83.33% (10/12) 82.35% (14/17) 66.67% (2/3) 71.43% (5/7)
src/modules/permissions/TimeRangeModule.sol 85.71% (12/14) 81.82% (18/22) 100.00% (2/2) 87.50% (7/8)
src/modules/validation/SingleSignerValidationModule.sol 92.00% (23/25) 81.58% (31/38) 62.50% (5/8) 90.00% (9/10)
src/modules/validation/WebAuthnValidationModule.sol 61.11% (11/18) 66.67% (18/27) 100.00% (3/3) 60.00% (6/10)
Total 94.22% (1190/1263) 93.19% (1492/1601) 78.64% (162/206) 84.86% (185/218)

Copy link

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉


🔗 Commit Hash: 60987e5

@jaypaik jaypaik merged commit 3a72a02 into develop Nov 21, 2024
7 checks passed
@jaypaik jaypaik deleted the 11-21-fix_alchemy-010_extraneous_event_fixes branch November 21, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants