Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump reference-implementation to v0.8.0 #323

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore: bump reference-implementation to v0.8.0 #323

merged 1 commit into from
Dec 12, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Dec 12, 2024 •
edited
Loading

No description provided.

@jaypaik jaypaik marked this pull request as ready for review December 12, 2024 02:41
@jaypaik Graphite App
Copy link
Collaborator Author

jaypaik commented Dec 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jaypaik jaypaik mentioned this pull request Dec 12, 2024
Merged
adamegyed
adamegyed approved these changes Dec 12, 2024
View reviewed changes
README.md
@@ -35,7 +35,7 @@ This repository contains:
The contracts conform to these ERC versions:

- ERC-4337: [v0.7.0](https://github.com/eth-infinitism/account-abstraction/blob/releases/v0.7/erc/ERCS/erc-4337.md)
- ERC-6900: [v0.8.0-rc.5](https://github.com/erc6900/reference-implementation/blob/v0.8.0-rc.5/standard/ERCs/erc-6900.md)
- ERC-6900: [v0.8.0](https://github.com/ethereum/ERCs/blob/c081c445424505d549e0236650917a2aaf3c5743/ERCS/erc-6900.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@jaypaik jaypaik force-pushed the 12-11-chore_bump_reference-implementation_to_v0.8.0 branch from ba9c8e9 to 150a208 Compare December 12, 2024 04:54
@jaypaik Graphite App
Copy link
Collaborator Author

jaypaik commented Dec 12, 2024 •
edited
Loading

Merge activity

  • Dec 12, 12:04 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 12, 12:05 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 12, 12:07 AM EST: A user merged this pull request with Graphite.

@jaypaik jaypaik changed the base branch from 12-11-chore_add_audit_reports to graphite-base/323 December 12, 2024 05:04
@jaypaik jaypaik changed the base branch from graphite-base/323 to develop December 12, 2024 05:05
@jaypaik jaypaik force-pushed the 12-11-chore_bump_reference-implementation_to_v0.8.0 branch from 150a208 to 17b3972 Compare December 12, 2024 05:05
@jaypaik jaypaik merged commit a3d7976 into develop Dec 12, 2024
7 checks passed
@jaypaik jaypaik deleted the 12-11-chore_bump_reference-implementation_to_v0.8.0 branch December 12, 2024 05:07
@github-actions GitHub Actions
Copy link

Contract sizes:

| Contract                      | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
| AccountFactory                | 6,121            | 6,595             | 18,455             | 42,557              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| Address                       | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| AllowlistModule               | 9,602            | 9,629             | 14,974             | 39,523              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| Base64                        | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| Create2                       | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ECDSA                         | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ERC165Checker                 | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ERC1967Utils                  | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ExecutionInstallDelegate      | 5,947            | 5,993             | 18,629             | 43,159              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| FCL_Elliptic_ZZ               | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| FCL_ecdsa                     | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| Math                          | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| MessageHashUtils              | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| ModularAccount                | 21,923           | 22,322            | 2,653              | 26,830              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| NativeTokenLimitModule        | 4,583            | 4,610             | 19,993             | 44,542              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| PaymasterGuardModule          | 1,827            | 1,854             | 22,749             | 47,298              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SafeERC20                     | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SemiModularAccount7702        | 23,153           | 23,545            | 1,423              | 25,607              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SemiModularAccountBytecode    | 23,635           | 24,034            | 941                | 25,118              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SemiModularAccountStorageOnly | 24,168           | 24,567            | 408                | 24,585              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SignatureChecker              | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SignedMath                    | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| SingleSignerValidationModule  | 3,646            | 3,673             | 20,930             | 45,479              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| StorageSlot                   | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| Strings                       | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| TimeRangeModule               | 2,204            | 2,231             | 22,372             | 46,921              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| WebAuthn                      | 17               | 46                | 24,559             | 49,106              |
|-------------------------------+------------------+-------------------+--------------------+---------------------|
| WebAuthnValidationModule      | 7,854            | 7,881             | 16,722             | 41,271              |

Code coverage:
| File | % Lines | % Statements | % Branches | % Funcs |
| script/Artifacts.sol | 91.67% (44/48) | 89.66% (26/29) | 100.00% (0/0) | 91.67% (22/24) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| script/DeployAccounts.s.sol | 100.00% (25/25) | 100.00% (23/23) | 100.00% (0/0) | 100.00% (5/5) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| script/DeployFactory.s.sol | 71.43% (30/42) | 71.05% (27/38) | 45.45% (5/11) | 100.00% (4/4) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| script/DeployModules.s.sol | 100.00% (24/24) | 100.00% (22/22) | 100.00% (0/0) | 100.00% (2/2) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| script/GetInitcodeHash.s.sol | 0.00% (0/47) | 0.00% (0/50) | 0.00% (0/12) | 0.00% (0/1) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| script/PredictAddresses.s.sol | 0.00% (0/53) | 0.00% (0/55) | 0.00% (0/6) | 0.00% (0/2) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| script/ScriptBase.sol | 69.39% (34/49) | 70.59% (36/51) | 37.50% (3/8) | 100.00% (11/11) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/AccountBase.sol | 100.00% (12/12) | 100.00% (7/7) | 100.00% (2/2) | 100.00% (4/4) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/AccountStorageInitializable.sol | 100.00% (21/21) | 100.00% (26/26) | 100.00% (5/5) | 100.00% (2/2) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/ModularAccount.sol | 100.00% (6/6) | 100.00% (6/6) | 100.00% (0/0) | 100.00% (3/3) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/ModularAccountBase.sol | 99.09% (326/329) | 96.24% (358/372) | 77.59% (45/58) | 100.00% (36/36) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/ModularAccountView.sol | 100.00% (32/32) | 100.00% (31/31) | 100.00% (3/3) | 100.00% (5/5) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/ModuleManagerInternals.sol | 94.03% (63/67) | 95.06% (77/81) | 63.64% (7/11) | 100.00% (4/4) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/SemiModularAccount7702.sol | 0.00% (0/9) | 0.00% (0/6) | 0.00% (0/1) | 0.00% (0/3) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/SemiModularAccountBase.sol | 90.48% (76/84) | 91.84% (90/98) | 64.71% (11/17) | 100.00% (16/16) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/SemiModularAccountBytecode.sol | 100.00% (8/8) | 100.00% (7/7) | 100.00% (1/1) | 100.00% (2/2) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/SemiModularAccountStorageOnly.sol | 77.78% (7/9) | 60.00% (6/10) | 100.00% (0/0) | 66.67% (2/3) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/account/TokenReceiver.sol | 33.33% (2/6) | 33.33% (1/3) | 100.00% (0/0) | 33.33% (1/3) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/factory/AccountFactory.sol | 79.03% (49/62) | 87.10% (54/62) | 50.00% (3/6) | 62.50% (10/16) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/helpers/ExecutionInstallDelegate.sol | 89.39% (59/66) | 89.47% (68/76) | 25.00% (2/8) | 100.00% (7/7) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/libraries/ExecutionLib.sol | 99.66% (297/298) | 98.89% (268/271) | 90.91% (30/33) | 100.00% (24/24) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/libraries/KnownSelectorsLib.sol | 100.00% (18/18) | 100.00% (34/34) | 100.00% (0/0) | 100.00% (2/2) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/libraries/LinkedListSetLib.sol | 94.83% (55/58) | 96.25% (77/80) | 66.67% (4/6) | 100.00% (8/8) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/libraries/MemManagementLib.sol | 100.00% (66/66) | 100.00% (70/70) | 100.00% (0/0) | 100.00% (12/12) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/libraries/ModuleInstallCommonsLib.sol | 64.71% (11/17) | 42.11% (8/19) | 75.00% (3/4) | 100.00% (3/3) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/libraries/ValidationLocatorLib.sol | 70.59% (72/102) | 71.74% (66/92) | 47.83% (11/23) | 85.00% (17/20) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/ModuleBase.sol | 100.00% (16/16) | 94.12% (16/17) | 100.00% (2/2) | 100.00% (3/3) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/permissions/AllowlistModule.sol | 81.90% (86/105) | 86.73% (98/113) | 78.26% (18/23) | 55.56% (10/18) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/permissions/NativeTokenLimitModule.sol | 88.14% (52/59) | 92.06% (58/63) | 100.00% (13/13) | 75.00% (9/12) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/permissions/PaymasterGuardModule.sol | 85.71% (18/21) | 84.21% (16/19) | 33.33% (1/3) | 85.71% (6/7) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/permissions/TimeRangeModule.sol | 88.89% (24/27) | 85.19% (23/27) | 100.00% (5/5) | 87.50% (7/8) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/validation/SingleSignerValidationModule.sol | 87.80% (36/41) | 84.21% (32/38) | 62.50% (5/8) | 100.00% (10/10) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| src/modules/validation/WebAuthnValidationModule.sol | 69.70% (23/33) | 70.37% (19/27) | 100.00% (3/3) | 70.00% (7/10) |
|---------------------------------------------------------+--------------------+--------------------+------------------+------------------|
| Total | 85.59% (1592/1860) | 85.80% (1650/1923) | 66.91% (182/272) | 87.59% (254/290) |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamegyed adamegyed adamegyed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaypaik @adamegyed