fix: [spearbit-54] use salt in eip-712 domain separator #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Awesome, thanks for removing the EIP712 dependency!
Thoughts on adding in another minor fix to the plugin within isValidSignature? Would love to optimize this:
-bytes memory messageData = encodeMessageData(msg.sender, abi.encode(digest));
-bytes32 messageHash = keccak256(messageData);
+bytes32 messageHash = getMessageHash(msg.sender, abi.encode(digest));Not sure if there's a more appropriate issue to file this under.
gpersoon
reviewed
Jan 8, 2024
| @@ -134,8 +140,7 @@ contract MultiOwnerPlugin is BasePlugin, IMultiOwnerPlugin, IERC1271, EIP712 { | |||
| /// an "Ethereum Signed Message" envelope before checking the signature in | |||
| /// the EOA-owner case. | |||
| function isValidSignature(bytes32 digest, bytes memory signature) public view override returns (bytes4) { | |||
| bytes memory messageData = encodeMessageData(msg.sender, abi.encode(digest)); | |||
| bytes32 messageHash = keccak256(messageData); | |||
| bytes32 messageHash = getMessageHash(msg.sender, abi.encode(digest)); | |||
There was a problem hiding this comment.
doublecheck: this is one keccak256() less than the previous version of the code, is this as intended?
There was a problem hiding this comment.
Definitely not. They should be the same.
Previously:
bytes32 messageHash
= keccak256(messageData)
= keccak256(encodeMessageData(msg.sender, abi.encode(digest)))
After change:
bytes32 messageHash
= getMessageHash(msg.sender, abi.encode(digest))
= keccak256(encodeMessageData(msg.sender, abi.encode(digest)))
jaypaik
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/spearbit-audits/alchemy-nov-review/issues/54