fix: [spearbit-62] cache owners_.length #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
commented
Jan 7, 2024
Comment on lines
+406
to
+413
| uint256 length = ownersToRemove.length; | ||
| for (uint256 i; i < length;) { | ||
| if (!ownerSet.tryRemove(associated, CastLib.toSetValue(ownersToRemove[i]))) { | ||
| revert OwnerDoesNotExist(ownersToRemove[i]); | ||
| } | ||
|
|
||
| unchecked { | ||
| ++j; | ||
| ++i; |
There was a problem hiding this comment.
This was updated for consistency.
jaypaik
force-pushed
the
01-07-fix_spearbit-66_remove_redundant_0_check
branch
from
5034db5 to
33dd87e
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-62_cache_owners_.length
branch
from
31e6986 to
60b812d
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-66_remove_redundant_0_check
branch
from
33dd87e to
50a363a
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-62_cache_owners_.length
branch
from
60b812d to
ca45dcf
Compare
fangting-alchemy
approved these changes
Jan 8, 2024
jaypaik
force-pushed
the
01-07-fix_spearbit-66_remove_redundant_0_check
branch
from
50a363a to
801d978
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-62_cache_owners_.length
branch
from
ca45dcf to
1bf7261
Compare
jaypaik
force-pushed
the
01-07-fix_spearbit-66_remove_redundant_0_check
branch
from
801d978 to
716f278
Compare
Base automatically changed from
01-07-fix_spearbit-66_remove_redundant_0_check
to
audit-2023-11-20
January 8, 2024 22:29
jaypaik
force-pushed
the
01-07-fix_spearbit-62_cache_owners_.length
branch
from
1bf7261 to
373e682
Compare
jaypaik
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/spearbit-audits/alchemy-nov-review/issues/62