fix: [spearbit-88] move SIG_VALIDATION_X to a global var #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
changed the title
|
There's also this code in return uint160(!validationSuccess ? 1 : 0) | (uint256(sessionKeyData.validUntil) << 160)
| (uint256(currentValidAfter) << (208)); |
|
sounds good! will make fixes after we merge @adam-alchemy's session key PR |
jaypaik
approved these changes
Jan 18, 2024
0xrubes
reviewed
Jan 23, 2024
| @@ -24,7 +24,9 @@ import { | |||
| AssociatedLinkedListSet, AssociatedLinkedListSetLib | |||
| } from "../../libraries/AssociatedLinkedListSetLib.sol"; | |||
| import {CastLib} from "../../libraries/CastLib.sol"; | |||
| import {SetValue, SENTINEL_VALUE} from "../../libraries/LinkedListSetUtils.sol"; | |||
| import { | |||
| SetValue, SENTINEL_VALUE, SIG_VALIDATION_PASSED, SIG_VALIDATION_FAILED | |||
There was a problem hiding this comment.
Unused import of SIG_VALIDATION_PASSED, else lgtm
There was a problem hiding this comment.
good catch! addressing this in: #113
jaypaik
added a commit
that referenced
this pull request
Jan 25, 2024
Co-authored-by: Jay Paik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
consolidate all usages of ERC4337 SIG_VALIDATION_PASSED, SIG_VALIDATION_FAILED into a global consts file
https://github.com/spearbit-audits/alchemy-nov-review/issues/88