fix: [spearbit-82] Session key init perms #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
reviewed
Jan 19, 2024
adam-alchemy
force-pushed
the
adam/session-key-init-perms
branch
from
44cf18d to
4dbf9d7
Compare
jaypaik
approved these changes
Jan 21, 2024
adam-alchemy
changed the title
adam-alchemy
force-pushed
the
adam/session-key-init-perms
branch
from
4dbf9d7 to
7b3108f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/spearbit-audits/alchemy-nov-review/issues/82
Additionally, the account clients team requested the ability to add permission updates to
addSessionKeyand to theonInstallmethod ofSessionKeyPluginto improve the developer experience of working with session keys.Solution
Change
updateKeyPermissionsfromexternalvisibility topublic.Add an extra
bytes[]parameter toaddSessionKey, which chains an internal call toupdateKeyPermissions.Add an extra
bytes32[]and abytes[][]parameter to the abi-decoding of the plugin install data, which contains tags and permissions for each key, respectively.updateKeyPermissionsdepends on the updates being acalldatatype, so we manually decode the type.Add test cases using these two paths for updating key permissions.
Update existing test cases for the new parameter format.