fix: [quanstamp-req] Contract data key #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Jan 19, 2024
adam-alchemy
force-pushed
the
adam/fix-contract-data-key
branch
from
615395b to
68f8c8f
Compare
jaypaik
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Quanstamp audit team suggested rearranging the bit-alignment of the key to
ContractDatainSessionKeyPermissionsBasefor consistency with other key definitions.Solution
Changing the comment describing the key layout:
// 12 padding zeros || associated address || CONTRACT_DATA_PREFIX || batch index || sessionKeyId || contractAddress || 12 padding zero bytes// 12 padding zeros || associated address || CONTRACT_DATA_PREFIX || batch index || sessionKeyId || 12 padding zero bytes || contractAddressChanging the calculation of
contractDataKey2:bytes32(bytes20(contractAddress))bytes32(uint256(uint160(contractAddress)))