fix: [spearbit-77] Refactor session key loading util functions #93
+25
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/spearbit-audits/alchemy-nov-review/issues/77
Solution
Add the recommended function to load a session key id and assert that it exists, renamed to
_loadSessionKeyId.Apply the recommended change to
getRequiredPaymaster.For clarity given the new function name, rename the previous function
_loadSessionKeyto_loadSessionKeyData.Use the new
_loadSessionKeyIdfunction in place of previous instances of_sessionKeyIdOf+_assertKeyExists._assertKeyExistsis within_loadSessionKeyId, so inline the function there instead.