Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [spearbit-60] add comment to explain that view functions are not given user op validation functions #95

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/plugins/owner/MultiOwnerPlugin.sol
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ contract MultiOwnerPlugin is BasePlugin, IMultiOwnerPlugin, IERC1271 {
});

// Update Modular Account's native functions to use userOpValidationFunction provided by this plugin
// The view functions `isValidSignature` and `eip712Domain` are excluded from being assigned a user
// operation validation function since they should only be called via the runtime path.
manifest.userOpValidationFunctions = new ManifestAssociatedFunction[](6);
manifest.userOpValidationFunctions[0] = ManifestAssociatedFunction({
executionSelector: this.updateOwners.selector,
Expand Down