Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pool] Reorder best operations each block using base fee #959

Closed
dancoombs opened this issue Dec 31, 2024 · 0 comments · Fixed by #962
Closed

[pool] Reorder best operations each block using base fee #959

dancoombs opened this issue Dec 31, 2024 · 0 comments · Fixed by #962
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dancoombs
Copy link
Collaborator

Describe the feature
Our current ordering logic looks at maxFeePerGas, this is insufficient for a correct priority fee based ordering of user operations. To order UOs correctly, we should be sorting by gas price, which requires the current baseFee to do the calculation. We can do this during our existing loop over the UOs in the pool maintenance function.

@dancoombs dancoombs added the enhancement New feature or request label Dec 31, 2024
@dancoombs dancoombs added this to the v0.5 milestone Dec 31, 2024
@dancoombs dancoombs self-assigned this Dec 31, 2024
@dancoombs dancoombs linked a pull request Dec 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant