Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pool): update best price on base fee change #962

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dancoombs
Copy link
Collaborator

Closes #959

@dancoombs dancoombs linked an issue Dec 31, 2024 that may be closed by this pull request
@dancoombs dancoombs force-pushed the danc/fix-max-replacement branch 6 times, most recently from 7cc270f to f22a02d Compare January 7, 2025 01:41
Base automatically changed from danc/fix-max-replacement to main January 7, 2025 02:01
@dancoombs dancoombs force-pushed the danc/fix-priority-sort branch 2 times, most recently from fd503ec to f95e263 Compare January 9, 2025 01:20
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.06%. Comparing base (cbd0734) to head (b519a49).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/pool.rs 96.95% <100.00%> (+0.23%) ⬆️
crates/pool/src/mempool/uo_pool.rs 92.17% <100.00%> (+0.01%) ⬆️
Flag Coverage Δ
unit-tests 59.06% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.22% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.97% <100.00%> (+0.25%) ⬆️
provider 19.49% <ø> (ø)
rpc 26.45% <ø> (ø)
sim 77.03% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.66% <ø> (ø)
utils 30.06% <ø> (ø)

@dancoombs dancoombs force-pushed the danc/fix-priority-sort branch from f95e263 to 9c85fa6 Compare January 9, 2025 14:44
@dancoombs dancoombs force-pushed the danc/fix-priority-sort branch from 9c85fa6 to b519a49 Compare January 9, 2025 18:07
@dancoombs dancoombs merged commit f88136c into main Jan 10, 2025
10 checks passed
@dancoombs dancoombs deleted the danc/fix-priority-sort branch January 10, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pool] Reorder best operations each block using base fee
2 participants