Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): fix pool candidates metrics to align with builder #943

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Use the same logic as the builder to determine candidate status in the mempool

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.98%. Comparing base (7aee108) to head (856d097).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/sim/src/precheck.rs 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/pool.rs 96.51% <100.00%> (-0.06%) ⬇️
crates/pool/src/mempool/uo_pool.rs 92.23% <100.00%> (-0.05%) ⬇️
crates/sim/src/precheck.rs 76.18% <0.00%> (-0.54%) ⬇️
Flag Coverage Δ
unit-tests 58.98% <67.56%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.15% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.20% <100.00%> (-0.13%) ⬇️
provider 20.25% <ø> (ø)
rpc 26.71% <ø> (ø)
sim 77.03% <0.00%> (-0.06%) ⬇️
tasks ∅ <ø> (∅)
types 67.61% <ø> (ø)
utils 30.06% <ø> (ø)

@dancoombs dancoombs merged commit 4803826 into main Dec 19, 2024
10 checks passed
@dancoombs dancoombs deleted the danc/fix-candidates branch December 19, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants