Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving unit tests for Aleph client commands #197

Draft
wants to merge 117 commits into
base: master
Choose a base branch
from
Draft

Improving unit tests for Aleph client commands #197

wants to merge 117 commits into from

Conversation

FunttasticLabs
Copy link

@FunttasticLabs FunttasticLabs commented Feb 9, 2024 •
edited by MHHukiewitz
Loading

Besides giving the Aleph CLI a full suite of integration tests with real API calls, we fixed several bugs:

  • Non-interactive environments are now handled gracefully everywhere
  • aleph program update is working again
  • Added several well-known exit codes for catched exeptions and errors

Test suite might sometimes be flaky due to HTTP 502 on the API side. We might need some retry mechanism in either the SDK or the CLI itself.

danilo-silva-funttastic and others added 28 commits January 25, 2024 16:28
@danilo-silva-funttastic
Moving fixture to a fixture folder.
d80fd03
@danilo-silva-funttastic
Splitting test_commands in different test files.
a81de1d
@danilo-silva-funttastic
Improving test_utils.py test and applying simple best practices.
120e20b
@danilo-silva-funttastic
Improving test files and adding some more new tests.
7a39210
@danilo-silva-funttastic
Moving about tests.
40f1ac8
@danilo-silva-funttastic
Adding unit tests for the domain command.
c2443b6
@danilo-silva-funttastic
Adding unit tests for the aggregate command.
0bb4df0
@AlvaroEFMota
Added a test for node compute
c826674
@danilo-silva-funttastic
Adding unit tests for the program command (WIP).
97ab342
@darley-silva-funttastic
Adding unit tests for the instance command.
f15f6f2
@danilo-silva-funttastic
Simple change.
3248923
@danilo-silva-funttastic
Merge branch 'aleph-master'
036fa4e
@danilo-silva-funttastic
Improving unit tests.
3f03b50
@darley-silva-funttastic
Improving unittests at test_aggregate.py.
a5b3138
@AlvaroEFMota
Improving unit test
437ca61
@danilo-silva-funttastic
Solving conflicts.
9b11505
@danilo-silva-funttastic
Merge branch 'master' of github.com:FunttasticLabs/aleph-client
3c8eb94
@danilo-silva-funttastic
Improving unit test files.
8e95d7c
@danilo-silva-funttastic
Updating unit tests from domain command.
c1c857f
@darley-silva-funttastic
Improving unittests at test_help.py.
1351412
@danilo-silva-funttastic
Adding unit tests for the file command.
b4d19a7
@AlvaroEFMota
Updating unit tests from instance command.
9f9ab14
@AlvaroEFMota
Updating unit tests from instance command.
3ebbd32
@danilo-silva-funttastic
Adding unit tests for the node command.
bc19380
@danilo-silva-funttastic
Merge branch 'master' of github.com:FunttasticLabs/aleph-client
585a043
@danilo-silva-funttastic
Adding unit tests for the help command.
3bfed9b
@darley-silva-funttastic
Improving unittests at test_message.py (wip).
cdee544
@AlvaroEFMota
Updating unit tests from program command.
3888b87
@MHHukiewitz MHHukiewitz marked this pull request as ready for review February 10, 2024 13:52
@MHHukiewitz MHHukiewitz mentioned this pull request Apr 29, 2024
Open
@MHHukiewitz MHHukiewitz requested review from hoh, nesitor and aliel May 2, 2024 11:38
@MHHukiewitz
Copy link
Member

@aliel I'm not sure about integration tests for the DNS service. Anything I should be careful about?

@Psycojoker Psycojoker changed the title Improving unit tests for Aleph client commads Improving unit tests for Aleph client commands Jun 27, 2024
@philogicae philogicae marked this pull request as draft August 21, 2024 11:32
@lgaroche lgaroche mentioned this pull request Sep 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoh hoh Awaiting requested review from hoh

@nesitor nesitor Awaiting requested review from nesitor

@aliel aliel Awaiting requested review from aliel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FunttasticLabs @hoh @danilo-silva-funttastic @MHHukiewitz @AlvaroEFMota @darley-silva-funttastic @alvaro-mota-funttastic