Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AttributeError: 'MicroVM' object has no attribute 'send_shutdown_message' #653

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Jul 4, 2024

Error reported on #652

src/aleph/vm/hypervisors/qemu/qemuvm.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.22%. Comparing base (4a9eabd) to head (478be7f).

Files Patch % Lines
src/aleph/vm/controllers/__main__.py 0.00% 3 Missing ⚠️
src/aleph/vm/hypervisors/qemu/qemuvm.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   61.25%   61.22%   -0.03%     
==========================================
  Files          65       65              
  Lines        5603     5607       +4     
  Branches      596      596              
==========================================
+ Hits         3432     3433       +1     
- Misses       2023     2026       +3     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor requested a review from olethanh July 5, 2024 13:05
@olethanh olethanh merged commit a3c5a8c into main Jul 5, 2024
22 of 24 checks passed
@Psycojoker Psycojoker deleted the hoh-fix-bug branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants