-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU list to /about/usage/system endpoint #726
Open
philogicae
wants to merge
8
commits into
main
Choose a base branch
from
proto-add-gpu-listing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 62.38% 62.36% -0.03%
==========================================
Files 70 73 +3
Lines 6235 6427 +192
Branches 507 529 +22
==========================================
+ Hits 3890 4008 +118
- Misses 2187 2257 +70
- Partials 158 162 +4 ☔ View full report in Codecov by Sentry. |
philogicae
force-pushed
the
proto-add-gpu-listing
branch
2 times, most recently
from
November 27, 2024 16:24
f37cc01
to
b0bcf57
Compare
philogicae
changed the title
Add GPU list to Machine Properties
Add GPU list to /about/usage/system endpoint
Nov 27, 2024
nesitor
force-pushed
the
proto-add-gpu-listing
branch
2 times, most recently
from
December 3, 2024 18:09
209e124
to
2cf7e70
Compare
nesitor
approved these changes
Dec 17, 2024
* Problem: If a user wants to assign a GPU to a QEmu VM he cannot do it. Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance. * Fix: Solved code quality issues * Fix: Solved compilation issue and fixed gpu logic. * Fix: Solved issue getting already running executions with GPU * Fix: Expose GPU support option in `status/config` endpoint * Fix: Applied some code review suggestions * Add migration * Fix: Allow to use the notify endpoint for GPU instances also. * Fix: Remove migration duplicity. * Fix: Changes DB initialization order to ensure that DB always exists before running the migrations. * Fix: Updated migration to only insert the column if isn't inside. --------- Co-authored-by: Olivier Le Thanh Duong <[email protected]>
nesitor
force-pushed
the
proto-add-gpu-listing
branch
from
December 17, 2024 17:52
bb5d74d
to
5506cbe
Compare
nesitor
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: ALEPH-328
Feature: Add list of available GPUs to /about/usage/system endpoint
TODO: Remove GpuProperties model after aleph-message update