Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU list to /about/usage/system endpoint #726

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

philogicae
Copy link
Member

@philogicae philogicae commented Nov 26, 2024

Jira: ALEPH-328

Feature: Add list of available GPUs to /about/usage/system endpoint

TODO: Remove GpuProperties model after aleph-message update

@philogicae philogicae self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 60.46512% with 85 lines in your changes missing coverage. Please review.

Project coverage is 62.36%. Comparing base (2f93e70) to head (387e9b3).

Files with missing lines Patch % Lines
...5c6ae643c69b_add_gpu_column_to_executions_table.py 0.00% 20 Missing ⚠️
src/aleph/vm/resources.py 74.60% 14 Missing and 2 partials ⚠️
src/aleph/vm/pool.py 25.00% 15 Missing ⚠️
src/aleph/vm/models.py 45.83% 13 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 14.28% 6 Missing ⚠️
src/aleph/vm/orchestrator/views/__init__.py 0.00% 6 Missing ⚠️
src/aleph/vm/conf.py 33.33% 1 Missing and 1 partial ⚠️
src/aleph/vm/hypervisors/qemu/qemuvm.py 86.66% 1 Missing and 1 partial ⚠️
...c/aleph/vm/hypervisors/qemu_confidential/qemuvm.py 0.00% 2 Missing ⚠️
src/aleph/vm/orchestrator/cli.py 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   62.38%   62.36%   -0.03%     
==========================================
  Files          70       73       +3     
  Lines        6235     6427     +192     
  Branches      507      529      +22     
==========================================
+ Hits         3890     4008     +118     
- Misses       2187     2257      +70     
- Partials      158      162       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae force-pushed the proto-add-gpu-listing branch 2 times, most recently from f37cc01 to b0bcf57 Compare November 27, 2024 16:24
@philogicae philogicae changed the title Add GPU list to Machine Properties Add GPU list to /about/usage/system endpoint Nov 27, 2024
@philogicae philogicae marked this pull request as ready for review November 27, 2024 16:27
@philogicae philogicae requested review from hoh and nesitor November 27, 2024 16:36
@nesitor nesitor force-pushed the proto-add-gpu-listing branch 2 times, most recently from 209e124 to 2cf7e70 Compare December 3, 2024 18:09
@nesitor nesitor requested a review from olethanh December 12, 2024 14:26
philogicae and others added 7 commits December 17, 2024 18:52
* Problem: If a user wants to assign a GPU to a QEmu VM he cannot do it.

Solution: Implement GPU assignation feature that will be pass-though to QEmu VMs with native performance.

* Fix: Solved code quality issues

* Fix: Solved compilation issue and fixed gpu logic.

* Fix: Solved issue getting already running executions with GPU

* Fix: Expose GPU support option in `status/config` endpoint

* Fix: Applied some code review suggestions

* Add migration

* Fix: Allow to use the notify endpoint for GPU instances also.

* Fix: Remove migration duplicity.

* Fix: Changes DB initialization order to ensure that DB always exists before running the migrations.

* Fix: Updated migration to only insert the column if isn't inside.

---------

Co-authored-by: Olivier Le Thanh Duong <[email protected]>
@nesitor nesitor force-pushed the proto-add-gpu-listing branch from bb5d74d to 5506cbe Compare December 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants