Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: improve chain data service #488

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

odesenfans
Copy link
Contributor

Problem: a few todos are still open on the chain data service.

Solution: improve and rename the get_chaindata method. The new prepare_sync_event_payload method now always returns an off-chain sync event (on-chain sync events never occur anyway). It also returns the result as a Pydantic model for more flexibility. Serialization is left upon the caller. We now use a Pydantic model to translate MessageDb objects in the correct format.

Problem: a few todos are still open on the chain data service.

Solution: improve and rename the `get_chaindata` method. The new
`prepare_sync_event_payload` method now always returns an off-chain sync
event (on-chain sync events never occur anyway). It also returns the
result as a Pydantic model for more flexibility. Serialization is left
upon the caller. We now use a Pydantic model to translate `MessageDb`
objects in the correct format.
@odesenfans odesenfans force-pushed the od-improve-chain-data-service branch from 9a3ec39 to fb9ebbe Compare October 20, 2023 13:52
@odesenfans odesenfans merged commit c9e4d8d into dev Oct 20, 2023
@odesenfans odesenfans deleted the od-improve-chain-data-service branch October 20, 2023 14:41
odesenfans added a commit that referenced this pull request Oct 23, 2023
Problem: a few todos are still open on the chain data service.

Solution: improve and rename the `get_chaindata` method. The new
`prepare_sync_event_payload` method now always returns an off-chain sync
event (on-chain sync events never occur anyway). It also returns the
result as a Pydantic model for more flexibility. Serialization is left
upon the caller. We now use a Pydantic model to translate `MessageDb`
objects in the correct format.
odesenfans added a commit that referenced this pull request Oct 27, 2023
Problem: a few todos are still open on the chain data service.

Solution: improve and rename the `get_chaindata` method. The new
`prepare_sync_event_payload` method now always returns an off-chain sync
event (on-chain sync events never occur anyway). It also returns the
result as a Pydantic model for more flexibility. Serialization is left
upon the caller. We now use a Pydantic model to translate `MessageDb`
objects in the correct format.
hoh pushed a commit that referenced this pull request Dec 8, 2023
Problem: a few todos are still open on the chain data service.

Solution: improve and rename the `get_chaindata` method. The new
`prepare_sync_event_payload` method now always returns an off-chain sync
event (on-chain sync events never occur anyway). It also returns the
result as a Pydantic model for more flexibility. Serialization is left
upon the caller. We now use a Pydantic model to translate `MessageDb`
objects in the correct format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant