Fix: warning on failure to close node cache properly #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
force-pushed
the
od-use-node-cache-as-async-context-manager
branch
2 times, most recently
from
183a494 to
5bc35e2
Compare
Problem: a warning occurs in the tests because of an improper cleanup of the Redis client object. Solution: make the NodeCache class an asynchronous context manager and make it clean up after itself.
odesenfans
force-pushed
the
od-use-node-cache-as-async-context-manager
branch
from
5bc35e2 to
b6548fb
Compare
hoh
pushed a commit
that referenced
this pull request
Dec 8, 2023
Problem: a warning occurs in the tests because of an improper cleanup of the Redis client object. Solution: make the NodeCache class an asynchronous context manager and make it clean up after itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: a warning occurs in the tests because of an improper cleanup of the Redis client object.
Solution: make the NodeCache class an asynchronous context manager and make it clean up after itself.