Fix: Old method upload #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHHukiewitz
requested changes
Dec 19, 2023
MHHukiewitz
requested changes
Dec 21, 2023
Comment on lines
+139
to
+157
|
|
||
| def read_file_with_max_size(self, max_size: int) -> Union[bytes, None]: | ||
| buffer_size = 64 * 1024 # 64 KB buffer size | ||
| content = b"" | ||
| total_read = 0 | ||
|
|
||
| while True: | ||
| chunk = self.file_field.file.read(buffer_size) | ||
|
|
||
| if not chunk: | ||
| break | ||
|
|
||
| total_read += len(chunk) | ||
| if total_read > max_size: | ||
| raise web.HTTPRequestEntityTooLarge() | ||
|
|
||
| content += chunk | ||
|
|
||
| return content if content else None |
There was a problem hiding this comment.
This part is actually insufficient and in the actual position, where we process the request, we need to use
await request.multipart()https://docs.aiohttp.org/en/stable/web_quickstart.html#file-uploads
You might have noticed a big warning in the example above. The general issue is that aiohttp.web.BaseRequest.post() reads the whole payload in memory, resulting in possible OOM errors. To avoid this, for multipart uploads, you should use aiohttp.web.BaseRequest.multipart() which returns a multipart reader:
|
Closed in favor #559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We require the old upload method to remain functional. In some cases, it may crash due to the HTTP client not setting the multipart header for the file_field.
Solution:
If no message is sent, we don't need to know the file size. We can simply read chunks until we reach the maximum size for unauthenticated uploads or end of file.