feat(overrides): add JSON patch for deployments #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #793 |
alexandrevilain
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Thanks for this awesome contribution.
I really like this!
JsonPatch is way more common than overrides.
Both are maybe too much.
Maybe we can provide this feature for every components (adminstools, services, monitoring, istio, ...) ? In a next PR. This is already a good start!
webhooks/temporalcluster_webhook.go
Outdated
| errs = append(errs, | ||
| field.Forbidden( | ||
| field.NewPath("spec", "services", "overrides", "deployment", "jsonPatch"), | ||
| fmt.Sprintf("Can't set JsonPatch when Spec is set on Deployment override"), |
There was a problem hiding this comment.
Suggested change
| fmt.Sprintf("Can't set JsonPatch when Spec is set on Deployment override"), | |
| "Can't set JsonPatch when Spec is set on Deployment override", |
No need for Sprintf :)
webhooks/temporalcluster_webhook.go
Outdated
| errs = append(errs, | ||
| field.Forbidden( | ||
| field.NewPath("spec", "services", string(service), "overrides", "deployment", "jsonPatch"), | ||
| fmt.Sprintf("Can't set JsonPatch when Spec is set on Deployment override"), |
There was a problem hiding this comment.
Suggested change
| fmt.Sprintf("Can't set JsonPatch when Spec is set on Deployment override"), | |
| "Can't set JsonPatch when Spec is set on Deployment override", |
|
alexandrevilain
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional functionality to override spec to allow for JSON patching. This is to allow users to patch arrays inside deployment overrides, as this functionality is not possible with StrategicPatchMerge. Follows similar functionality to what Kustomize provides.