Skip to content

Commit

Permalink
Don't allow input params from GitHub actions, forks can define their …
Browse files Browse the repository at this point in the history
…own secret to run.
  • Loading branch information
alexdlaird committed Oct 31, 2024
1 parent 135c499 commit 7593d20
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,6 @@ name: Integration Test
on:
workflow_call:
workflow_dispatch:
inputs:
AMAZON_USERNAME:
type: string
description: Amazon username of account to run tests against
AMAZON_PASSWORD:
type: string
description: Amazon password of account to run tests against
TO_PHONE_NUMBER:
type: string
description: Phone number to which 2FA login codes will be sent
schedule:
- cron: "0 17 * * 1"

Expand All @@ -22,13 +12,13 @@ jobs:

env:
FORCE_COLOR: 1
AMAZON_USERNAME: ${{ inputs.AMAZON_USERNAME || secrets.AMAZON_USERNAME }}
AMAZON_PASSWORD: ${{ inputs.AMAZON_PASSWORD || secrets.AMAZON_PASSWORD }}
AMAZON_USERNAME: ${{ secrets.AMAZON_USERNAME }}
AMAZON_PASSWORD: ${{ secrets.AMAZON_PASSWORD }}
START_INDEX_FULL_HISTORY: ${{ vars.START_INDEX_FULL_HISTORY }}
TWILIO_ACCOUNT_SID: ${{ secrets.TWILIO_ACCOUNT_SID }}
TWILIO_AUTH_TOKEN: ${{ secrets.TWILIO_AUTH_TOKEN }}
TWILIO_PHONE_NUMBER: ${{ secrets.TWILIO_PHONE_NUMBER }}
TO_PHONE_NUMBER: ${{ inputs.TO_PHONE_NUMBER || secrets.TO_PHONE_NUMBER }}
TO_PHONE_NUMBER: ${{ secrets.TO_PHONE_NUMBER }}
NGROK_AUTHTOKEN: ${{ secrets.NGROK_AUTHTOKEN }}

runs-on: ubuntu-latest
Expand Down

0 comments on commit 7593d20

Please sign in to comment.