Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: port regenerated incentives and heartbeat models #917

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Jan 11, 2025

Regenerate models and pick required changed: BlockHeaderResponse + Hearbeat.
Regenerating everything produced a quite large diff due to some pre-checks removal (not sure why did they do from the generator) and some extra changes from spec files that are not really important.

Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we skipping support for the cross SDK tests (may have to explicitly disable if so)?

Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we skipping support for the cross SDK tests (may have to explicitly disable if so)?

@algorandskiy
Copy link
Contributor Author

I'm working on the followup PR with deserialization code and tests.

@algorandskiy algorandskiy changed the title api: port regenerated models api: port regenerated incentives and heartbeat models Jan 14, 2025
@algorandskiy algorandskiy merged commit 76dca7a into v2.9-develop Jan 14, 2025
2 checks passed
@algorandskiy algorandskiy deleted the pavel/v2-heartbeat-models branch January 14, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants