Add tests for utils / setting up INI file #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests that cover some items in #13 for the util functions for reading/writing to an INI file:
This PR also adds a few fixes to the library that were caught while writing tests, such as:
prelude.rs
if none were specified in the INI fileNote, related to #7 and #15: we should let users know that
BootstrapConfig
will default to generate the keypairs ingenerate_keypair_from_protobuf
even though the INI file doesn't have the required[auth]
field. We may want to enforce that users have this compulsory field by panicking with a log message or we don't panic but log that the fallback was used. WDYT @thewoodfish ?Please merge once reviewed =)