Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Component: Navigation Top List Bar - UI component #272 #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Admin] Component: Navigation Top List Bar - UI component #272 #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 44 additions & 11 deletions src/AzureOpenAIProxy.PlaygroundApp/Components/Layout/MainLayout.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,52 @@
@inherits LayoutComponentBase

<div class="page">
@if (this._isAdmin == true)
{
<div class="sidebar">
<NavMenu />
<FluentLayout Style="margin-top: 10px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout 컴포넌트하고 MainLayout 컴포넌트하고 어떤게 더 맞을 것 같은가요? 저는 MainLayout 같아 보이긴 하는데... 어떻게 생각하세요?


<FluentHeader>
Azure OpenAI Proxy Playground
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 Playground는 어드민 화면에서는 맞지 않으니... 그냥 빼거나 아니면 URL에 따라 /admin 페이지일 경우 Azure OpenAI Proxy &ndash Dashboard하고 /playground 페이지일 경우에는 Azure OpenAI Proxy &ndash; Playground 처럼 다이나믹하게 구성할 수 있나요?

<div style="margin-left: auto;">
<FluentButton IconEnd="@(new Icons.Regular.Size20.Person().WithColor("Blue"))">
Login
</FluentButton>
Comment on lines +8 to +10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 이 아이콘을 GitHub 아이콘으로 바꿀 수도 있나요?
  • 그리고 문자열은 Login with로 바꾸면 좋을 듯?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://simpleicons.org 여기 참조해 보면 좋을 듯?

</div>
</FluentHeader>

<FluentStack Orientation="Orientation.Horizontal" Width="100%">
<div>
<FluentNavMenu Width="250">
<FluentNavLink Icon="@(new Icons.Regular.Size24.Globe())" Href="/">AOAI Proxy Playground
</FluentNavLink>
<FluentNavLink Icon="@(new Icons.Regular.Size24.Home())" Href="/">Home</FluentNavLink>
@if (this._isAdmin == true)
{
<FluentNavLink Icon="@(new Icons.Regular.Size24.Board())" Href="/admin">Admin Dashboard</FluentNavLink>
}
</FluentNavMenu>
</div>
Comment on lines +15 to 25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 네비 메뉴는 어드민 페이지에서만 보이게 해 주세욥. 플레이그라운드에서는 화면을 풀로 다 쓸 수 있으면 좋겠습니다.

}

<main>
<article class="content px-4">
@Body
</article>
</main>
<div style="width: 100%;">
<div>
@Body
</div>
</div>
</FluentStack>
</FluentLayout>

@* <div class="page">
<AdminTopListBar />
@if (this._isAdmin == true)
{
<div class="sidebar">
<NavMenu />
</div>
}

<main>
<article class="content px-4">
@Body
</article>
</main>
</div> *@

<div id="blazor-error-ui">
An unhandled error has occurred.
Expand Down
4 changes: 3 additions & 1 deletion src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Admin.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
@page "/admin"

<PageTitle>Admin Page</PageTitle>
@*
<AdminTopListBar /> *@

<h1>Admin Dashboard Page</h1>
<h3>Admin Dashboard Page</h3>
Comment on lines 3 to +7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞서 남긴 코멘트대로 하면 여기서 살짝 논리를 바꾸면 될 듯?

Loading