Skip to content

Commit

Permalink
Remove support for Python 3.7 and 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronreidsmith authored and tgsmith61591 committed Nov 7, 2024
1 parent 22cb5ce commit 9526f13
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 57 deletions.
52 changes: 3 additions & 49 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ commands:
-v `pwd`:/app \
-w /app \
--env-file vars.env \
python:3.7 \
python:3.9 \
./build_tools/circle/deploy.sh
jobs:
Expand All @@ -94,7 +94,7 @@ jobs:
# larger unit tests, and to avoid multiple setup steps that can slow the pipeline down
test-sanity:
docker:
- image: python:3.7
- image: python:3.9
working_directory: ~/pmdarima
steps:
- checkout
Expand Down Expand Up @@ -130,26 +130,6 @@ jobs:
python -c 'import pmdarima as pm; print(pm.__version__)'
# --- Unit tests ---
# These are all executed on `machine` executors, since they require DinD to build the whl
# files and perform the whl repair for manylinux support.
test-unit-cpython37:
machine:
image: ubuntu-2004:202111-02
working_directory: ~/pmdarima
steps:
- checkout
- build-test-and-persist:
pythonversion: "3.7"

test-unit-cpython38:
machine:
image: ubuntu-2004:202111-02
working_directory: ~/pmdarima
steps:
- checkout
- build-test-and-persist:
pythonversion: "3.8"

test-unit-cpython39:
machine:
image: ubuntu-2004:202111-02
Expand Down Expand Up @@ -219,16 +199,6 @@ jobs:
#
# ############################################

deploy-cpython37-whl:
machine:
image: ubuntu-2004:202111-02
working_directory: ~/pmdarima
steps:
- checkout
- restore-whl-file:
key: "3.7"
- deploy-to-pypi

deploy-cpython38-whl:
machine:
image: ubuntu-2004:202111-02
Expand Down Expand Up @@ -287,7 +257,7 @@ jobs:
# GH_TOKEN (the personal Git token with pushes enabled)
deploy-doc:
docker:
- image: python:3.7
- image: python:3.9
working_directory: ~/pmdarima
steps:
- checkout
Expand All @@ -306,10 +276,6 @@ workflows:
# run on test and tag
- test-sanity:
filters: *test-filters
- test-unit-cpython37:
filters: *test-filters
- test-unit-cpython38:
filters: *test-filters
- test-unit-cpython39:
filters: *test-filters
- test-unit-cpython310:
Expand All @@ -323,8 +289,6 @@ workflows:
- testing-passed:
requires:
- test-sanity
- test-unit-cpython37
- test-unit-cpython38
- test-unit-cpython39
- test-unit-cpython310
- test-unit-cpython311
Expand All @@ -339,16 +303,6 @@ workflows:
- testing-passed
filters: *test-filters

- deploy-cpython37-whl:
filters: *deploy-filters
requires:
- deploy-doc

- deploy-cpython38-whl:
filters: *deploy-filters
requires:
- deploy-doc

- deploy-cpython39-whl:
filters: *deploy-filters
requires:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
build-and-deploy:
strategy:
matrix:
python3-minor-version: [7, 8, 9, 10, 11, 12]
python3-minor-version: [9, 10, 11]
# TODO: Figure out macos-14/macos-latest
os: [macos-13, ubuntu-latest, windows-latest]
defaults:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![CircleCI](https://circleci.com/gh/alkaline-ml/pmdarima.svg?style=svg)](https://circleci.com/gh/alkaline-ml/pmdarima)
[![Github Actions Status](https://github.com/alkaline-ml/pmdarima/workflows/Mac%20and%20Windows%20Builds/badge.svg?branch=master)](https://github.com/alkaline-ml/pmdarima/actions?query=workflow%3A%22Mac+and+Windows+Builds%22+branch%3Amaster)
[![codecov](https://codecov.io/gh/alkaline-ml/pmdarima/branch/master/graph/badge.svg)](https://codecov.io/gh/alkaline-ml/pmdarima)
![Supported versions](https://img.shields.io/badge/python-3.7+-blue.svg)
![Supported versions](https://img.shields.io/badge/python-3.9+-blue.svg)
![Downloads](https://img.shields.io/badge/dynamic/json?color=blue&label=downloads&query=%24.total&url=https%3A%2F%2Fstore.zapier.com%2Fapi%2Frecords%3Fsecret%3D1e061b29db6c4f15af01103d403b0237)
![Downloads/Week](https://img.shields.io/badge/dynamic/json?color=blue&label=downloads%2Fweek&query=%24.weekly&url=https%3A%2F%2Fstore.zapier.com%2Fapi%2Frecords%3Fsecret%3D1e061b29db6c4f15af01103d403b0237)

Expand Down Expand Up @@ -118,7 +118,7 @@ with open('model.pkl', 'rb') as pkl:

### Availability

`pmdarima` is available on PyPi in pre-built Wheel files for Python 3.7+ for the following platforms:
`pmdarima` is available on PyPi in pre-built Wheel files for Python 3.9+ for the following platforms:

* Mac (64-bit)
* Linux (64-bit manylinux)
Expand Down
4 changes: 1 addition & 3 deletions build_tools/circle/build_wheel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ function build_wheel {

# https://www.python.org/dev/peps/pep-0513/#ucs-2-vs-ucs-4-builds
ucs_tag=""
if [ "$pyver" = "3.7" ]; then
ucs_tag="m"
elif [ "$ucs_setting" = "ucs4" ]; then
if [ "$ucs_setting" = "ucs4" ]; then
ucs_tag="${ucs_tag}u"
fi

Expand Down
2 changes: 2 additions & 0 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ v0.8.1) will document the latest features.
-------------------------------------------------

* Pin numpy to ``<2.0.0`` while work is done to support numpy ``>=2.0.0``
* Remove support for Python 3.7 (end-of-life 2023-06-23)
* Remove support for Python 3.8 (end-of-life 2024-10-07)

`v2.0.3 <https://alkaline-ml.com/pmdarima/2.0.3>`_
-------------------------------------------------
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
import builtins

# Minimum allowed version
MIN_PYTHON = (3, 7)
IS_PYTHON_312 = sys.version_info[0] == 3 and sys.version_info[1] >= 12
MIN_PYTHON = (3, 9)

# Hacky (!!), adopted from sklearn. This sets a global variable
# so pmdarima __init__ can detect if it's being loaded in the setup
Expand Down Expand Up @@ -239,7 +239,6 @@ def do_setup():
'Operating System :: Unix',
'Operating System :: MacOS',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
Expand Down

0 comments on commit 9526f13

Please sign in to comment.