[RW-13720][risk=no] Cleaned up credit exhaustion cron language #8994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrii
commented
Dec 13, 2024
There was a problem hiding this comment.
Duplicating "freecredit" and iinitialcredits" to ensure deploy safety. Plan to delete freetier later.
evrii
commented
Dec 13, 2024
There was a problem hiding this comment.
Change Expiry to Exhaustion to make naming more intuitive.
evrii
changed the title
yonghaoy
reviewed
Dec 13, 2024
| @@ -1,7 +1,7 @@ | |||
| cron: | |||
| - url: /v1/cron/checkObjectNameSize | |||
| schedule: every 24 hours | |||
| - url: /v1/cron/checkFreeTierBillingUsage | |||
| - url: /v1/cron/checkForInitialCreditUsage | |||
There was a problem hiding this comment.
this might break Monitoring alert https://github.com/all-of-us/workbench-terraform-modules/tree/main/modules/workbench/modules/monitoring/modules
api/config/config_local.json
Outdated
| @@ -23,17 +23,25 @@ | |||
| "projectNamePrefix": "aou-rw-local1-", | |||
| "exportBigQueryTable": "all-of-us-workbench-test-bd.billing_data.rw_test_firecloud_view", | |||
| "defaultFreeCreditsDollarLimit": 300.0, | |||
| "defaultInitialCreditDollarLimit": 300.0, | |||
| "freeTierCostAlertThresholds": [ | |||
There was a problem hiding this comment.
do we need to keep the old ones and user another PR to delete? If our code switches to use the new config, then we can just delete them now. Same for all other configs
yonghaoy
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up language of credit exhaustion cron as much as practical.
This largely involved changing freetrier to initialcredit and changing expiry to exhaustion.
PR checklist
[risk=no|low|moderate|severe]in the PR title as outlined in CONTRIBUTING.md.