-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RW-13823][risk=no] Add AIAN research purpose questions #9037
Open
evrii
wants to merge
15
commits into
main
Choose a base branch
from
eric/aianWorkspaceCreationDB
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+421
−5
Open
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6bbbe6e
Add aianResearchPlan to entities and database.
evrii 172db86
Fix typo
evrii 87ef7c4
Setup basics for AIAN Research plan selection.
evrii cdd240c
Update db columns
evrii d801f9d
Update how UI handles AIAN research type selection
evrii 7b2a607
Added ability to edit AIAN questions.
evrii 0e22468
Ensure that aianplan and details are not saved when not appropriate
evrii 397380e
Ensure that AIAN research plan fields show up only where appropriate.
evrii 0ba37fe
Make CDR v8 by default and v7 as an alt.
evrii c2dfb49
Cleanup
evrii f4ae914
Cleanup
evrii baacb21
Merge main
evrii fcf89c1
Provide validation for AIAN questions
evrii c892cbf
Add validation and appropriate testing
evrii 8398135
Add default values to account for duplication and edit cases.
evrii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
api/db/changelog/db.changelog-249-add-aian-research-columns.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<databaseChangeLog | ||
xmlns="http://www.liquibase.org/xml/ns/dbchangelog" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd"> | ||
<changeSet author="eric" id="db.changelog-249-add-aian-research-plan-column"> | ||
<addColumn tableName="workspace"> | ||
<column name="rp_aian_research_type" type="ENUM('EXCLUSIVE_AI_AN_POPULATION','CASE_CONTROL_AI_AN','FINDINGS_BY_AI_AN', 'NO_AI_AN_ANALYSIS')"/> | ||
<column name="rp_aian_research_details" type="varchar(1000)"/> | ||
</addColumn> | ||
</changeSet> | ||
</databaseChangeLog> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The getters/setters seem a little strange here, because it uses Aian instead of AIAN.
If I rename it to the later, the mapping breaks. Happy to adjust if you have a preference.