Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[risk=low][RW-14199] Bump some packages related to google-auth #9041

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[risk=low][RW-14199] Bump some packages related to google-auth #9041

wants to merge 7 commits into from

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Jan 14, 2025 •
edited
Loading

Part of our continued attempts to reliably run commands without seeing invalid_grant / JWT errors.

Tested locally, no apparent problems.

PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

jmthibault79
jmthibault79 commented Jan 14, 2025
View reviewed changes
api/build.gradle
implementation 'com.google.api-client:google-api-client-appengine:2.5.0'
implementation 'com.google.auth:google-auth-library-appengine:1.23.0'
implementation 'com.google.auth:google-auth-library-oauth2-http:1.23.0'
implementation 'com.google.api-client:google-api-client-appengine:2.7.1'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mainly searching for "auth", seeing which packages were referenced in error messages, and trial and error.

@jmthibault79 jmthibault79 changed the title [risk=low][no ticket] Bump some packages related to google-auth [risk=low][RW-14199] Bump some packages related to google-auth Jan 14, 2025
jmthibault79
jmthibault79 commented Jan 14, 2025
View reviewed changes
api/build.gradle
GSON_VERSION = '2.10'
HIBERNATE_VERSION = '6.5.2.Final'
JACKSON_VERSION = '2.17.2'
JACKSON_VERSION = '2.18.2'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also opportunistically bumping a few more packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmthibault79