Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): update examples to use ProviderBuilder best practices #43

Merged
merged 5 commits into from
Apr 3, 2024
Merged

fix(provider): update examples to use ProviderBuilder best practices #43

merged 5 commits into from
Apr 3, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Apr 2, 2024 •
edited
Loading

Motivation

Closes: #42
Blocked by: alloy-rs/alloy#436

Solution

This solution comes with the recognition that for the time being we continue to iterate on the API, narrowing down to the best. Therefore the term best practice evolves over time, goal is to consistently show the best version of the API across the examples.

  • Change ReqwestProvider to use ProviderBuilder
  • Use on_ws and on_ipc methods on the builder

PR Checklist

  • Added Documentation
  • Breaking changes

zerosnacks
zerosnacks commented Apr 2, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@zerosnacks zerosnacks requested review from prestwich and gakonst April 2, 2024 10:33
@zerosnacks zerosnacks removed the blocked label Apr 3, 2024
@zerosnacks zerosnacks marked this pull request as ready for review April 3, 2024 08:01
@zerosnacks zerosnacks requested a review from yash-atreya April 3, 2024 08:01
@zerosnacks zerosnacks mentioned this pull request Apr 3, 2024
Closed
@zerosnacks
Copy link
Member Author

Going to merge this as an incremental step

Concretely two tickets stemming from this that will lead to a follow up:

@zerosnacks zerosnacks merged commit 2b6ae9d into main Apr 3, 2024
4 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/update-examples-providerbuilder branch April 3, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich

@gakonst gakonst Awaiting requested review from gakonst

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update examples to use ProviderBuilder best practice
3 participants
@zerosnacks @prestwich @mattsse