Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(queries): query examples #6

Merged
merged 9 commits into from
Mar 25, 2024
Merged

feat(queries): query examples #6

merged 9 commits into from
Mar 25, 2024

Conversation

yash-atreya
Copy link
Member

  • query_logs
  • query_deployed_bytecode
  • query_contract_storage

@yash-atreya yash-atreya self-assigned this Mar 14, 2024
@yash-atreya yash-atreya mentioned this pull request Mar 14, 2024
Closed
3 tasks
@zerosnacks
Copy link
Member

Made some minor changes, largely cosmetic.

klkvr
klkvr approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, lgtm overall!

examples/queries/examples/query_logs.rs Outdated Show resolved Hide resolved
examples/queries/examples/query_contract_storage.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya requested a review from mattsse March 18, 2024 00:12
mattsse
mattsse approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Client type hint no longer necessary?

examples/queries/examples/query_logs.rs Outdated Show resolved Hide resolved
zerosnacks
zerosnacks requested changes Mar 25, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
examples/queries/Cargo.toml Outdated Show resolved Hide resolved
examples/queries/examples/query_deployed_bytecode.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya merged commit aff3dfe into main Mar 25, 2024
2 checks passed
@zerosnacks zerosnacks deleted the query_examples branch March 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@gakonst gakonst gakonst approved these changes

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@mattsse mattsse Awaiting requested review from mattsse

Assignees

@yash-atreya yash-atreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yash-atreya @zerosnacks @gakonst @mattsse @klkvr