-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix clang9/nvcc11.2 boost bug #2294
fix clang9/nvcc11.2 boost bug #2294
Conversation
8ddbb25
to
6bd62a6
Compare
- disable atomic_ref for clang<=11&nvcc<11.6 This PR fix current CI issues with clang + nvcc.
6bd62a6
to
86f0831
Compare
Fix error by explicit linking to the right namespace. ``` AtomicAtomicRef.hpp(59,25): error C2039: 'atomic_ref': is not a member of 'alpaka::trait::detail' ```
@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc. |
Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues. |
ok, i will try in the evening. I will document it if possible so that people can do easily.... |
Ok works, great. Thank you good for compile errors. |
This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.
The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.
Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.