Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang9/nvcc11.2 boost bug #2294

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

psychocoderHPC
Copy link
Member

@psychocoderHPC psychocoderHPC commented Jun 17, 2024

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.

/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
  • disable atomic_ref for clang<12&nvcc<11.6

The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.

Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

@psychocoderHPC psychocoderHPC added this to the 1.2.0 milestone Jun 17, 2024
@psychocoderHPC psychocoderHPC marked this pull request as draft June 17, 2024 08:57
@psychocoderHPC psychocoderHPC force-pushed the fix-CIClang9Nvcc branch 3 times, most recently from 8ddbb25 to 6bd62a6 Compare June 18, 2024 07:29
@psychocoderHPC psychocoderHPC marked this pull request as ready for review June 18, 2024 07:29
@psychocoderHPC psychocoderHPC requested a review from fwyzard June 18, 2024 07:30
@psychocoderHPC
Copy link
Member Author

@fwyzard You observed already in #2288 issues with clang+nvcc and due to #2296 it shows that more combinations are affected.

- disable atomic_ref for clang<=11&nvcc<11.6

This PR fix current CI issues with clang + nvcc.
@psychocoderHPC psychocoderHPC mentioned this pull request Jun 18, 2024
1 task
Fix error by explicit linking to the right namespace.

```
AtomicAtomicRef.hpp(59,25): error C2039: 'atomic_ref': is not a member of 'alpaka::trait::detail'
```
@mehmetyusufoglu
Copy link
Contributor

mehmetyusufoglu commented Jun 18, 2024

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.

/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6

The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.

Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.

@psychocoderHPC
Copy link
Member Author

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.

/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6

The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.
Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.

Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues.

@mehmetyusufoglu
Copy link
Contributor

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.

/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6

The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.
Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.

Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues.

ok, i will try in the evening. I will document it if possible so that people can do easily....

@mehmetyusufoglu
Copy link
Contributor

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.

/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6

The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.
Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.

Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues.

ok, i will try in the evening. I will document it if possible so that people can do easily....

Ok works, great. Thank you good for compile errors.

@fwyzard fwyzard self-requested a review June 19, 2024 13:21
@fwyzard fwyzard merged commit ed0a95f into alpaka-group:develop Jun 19, 2024
22 checks passed
@psychocoderHPC psychocoderHPC deleted the fix-CIClang9Nvcc branch June 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants