Fix template arguments of SYCL buffer specializations #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
reviewed
Nov 21, 2024
test/unit/mem/buf/src/BufTest.cpp
Outdated
| { | ||
| return alpaka::allocBuf<TElem, TIdx>(dev, extent); | ||
| } | ||
| #elif defined(ALPAKA_ACC_GPU_HIP_ENABLED) |
There was a problem hiding this comment.
I would change
Suggested change
| #elif defined(ALPAKA_ACC_GPU_HIP_ENABLED) | |
| #endif | |
| #if defined(ALPAKA_ACC_GPU_HIP_ENABLED) |
so if a test enables multiple back-ends they can all be tested.
AuroraPerego
force-pushed
the
fixUsingBuf
branch
from
4e53431 to
aff1a6c
Compare
|
Looks good to me 👍🏻 |
fwyzard
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufCpuSycl,BufFpgaSyclIntel, andBufGpuSyclIntelwere still templated on the platform instead of being templated on the Tag.We are not using them anywhere in the alpaka tests, that's why this issue has not been spotted before.
I changed
memBufTestto use them explicitly to avoid similar issues in the future, let me know if it's ok.