Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add math functions for complex type for the oneAPI backend #2436

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

AuroraPerego
Copy link
Contributor

The oneAPI backend did not have the specialization of math functions on the device for complex types.
I moved (to avoid code duplication) the specializations done for CUDA/HIP to Complex.hpp to allow the oneAPI backend to use them as well.

@AuroraPerego AuroraPerego force-pushed the SYCLcomplex branch 2 times, most recently from d01a3d5 to e3fb276 Compare December 6, 2024 09:33
@AuroraPerego
Copy link
Contributor Author

This failure in the tests with windows does not seem related to the PR:

+++ choco uninstall cmake.install
Chocolatey v2.4.0
Uninstalling the following packages:
cmake.install

cmake.install v3.31.1
 Running auto uninstaller...
 [AutoUninstaller] The installation source for this product is not available. Verify that the source exists and that you can access it.
 [AutoUninstaller] 
 [AutoUninstaller] 
 Auto uninstaller failed. Please remove machine installation manually.
 Exit code was 1612
 cmake.install has been successfully uninstalled.

Chocolatey uninstalled 1/1 packages. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Warnings:
 - cmake.install -  Auto uninstaller failed. Please remove machine installation manually.
 Exit code was 1612

@SimeonEhrig
Copy link
Member

This failure in the tests with windows does not seem related to the PR:

+++ choco uninstall cmake.install
Chocolatey v2.4.0
Uninstalling the following packages:
cmake.install

cmake.install v3.31.1
 Running auto uninstaller...
 [AutoUninstaller] The installation source for this product is not available. Verify that the source exists and that you can access it.
 [AutoUninstaller] 
 [AutoUninstaller] 
 Auto uninstaller failed. Please remove machine installation manually.
 Exit code was 1612
 cmake.install has been successfully uninstalled.

Chocolatey uninstalled 1/1 packages. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Warnings:
 - cmake.install -  Auto uninstaller failed. Please remove machine installation manually.
 Exit code was 1612

The windows CI problem is solved. You can rebase.

@psychocoderHPC psychocoderHPC merged commit 216552a into alpaka-group:develop Jan 13, 2025
22 checks passed
@psychocoderHPC
Copy link
Member

@AuroraPerego could you open a PR with the same changes against the dev branch for 1.3
Since no C++20 is required all changes can be picked with cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants