-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file_exist function to std #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but a new function also needs to be added to tests
How to write a test about file operations? I saw that the test does not include a test for file_read/file_write. Can you give me an example? |
that is weird that there are no tests for those functions. tests are written like this: #[test]
fn name_of_the_test() {
test_amber!("// put amber code here", "what the code should output");
} i guess that if the other file functions are not covered for now, we could sweep that issue under the carpet in the scope of this PR. (see #117) |
I think that we will focus on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add dir_exist
function as well to keep things symmetrical
No description provided.