Implement tangent computation for OBJ loading #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This effectively loads per face tangents, since it computes tangents per tri without respect to neighboring tri's. The most straightforward way to compute per vertex tangents probably involves implementing proper indexing instead of duplicating shared vertices. |
|
Okay, this should now compute per vertex tangents. They should still probably be weighted by face area or some other method. |
|
You could use this crate, mikktspace is pretty standard as a very effective
tangent space now. https://github.com/gltf-rs/mikktspace
…On Sun, Feb 9, 2020, 10:13 AM Grant Moyer ***@***.***> wrote:
Okay, this should now compute per vertex tangents. They should still
probably be weighted by face area or some other method.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#267?email_source=notifications&email_token=AAGYXHYVEGGVZJ4UBMW6KELRCA2UXA5CNFSM4KRX23IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGSIZQ#issuecomment-583869542>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGYXH4UEYLCUBPDGCTJIZDRCA2UXANCNFSM4KRX23IA>
.
|
|
Thanks for the pointer. I was surprised how non-standardized tangent space computation was when I looked into it. I'm marking this ready for review now. |
|
Is there anything blocking this that I could fix or help with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #266
I went ahead and implemented indiscriminate tangent computation during OBJ file loading. I should be relatively straightforward to convert it to one of the other options mention in the issue if that's desirable.