fix: remove duplicate entries in PackageXml

amtrack · Feb 12, 2024 · cde3468 · cde3468
1 parent 3891136
commit cde3468
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/package-xml.ts b/src/package-xml.ts
@@ -30,7 +30,7 @@ export class PackageXml {
       .map((entry) => {
         const [type, components] = entry;
         return {
-          members: components.map((component) => component.fullName).sort(compareAlphanumeric),
+          members: [...new Set(components.map((component) => component.fullName).sort(compareAlphanumeric))],
           name: type,
         };
       })

diff --git a/test/package-xml.test.ts b/test/package-xml.test.ts
@@ -14,6 +14,23 @@ describe("PackageXml", () => {
     fs.readFileSync(path.join(__dirname, "fixtures", "package", "package.json"), "utf8"),
   );
 
+  describe("#toString()", () => {
+    it("removes duplicate entries", () => {
+      const pkg = new PackageXml([
+        { type: "EmailTemplate", fullName: "unfiled$public" },
+        { type: "EmailTemplate", fullName: "unfiled$public" },
+      ]);
+      expect(pkg.toJSON()).to.deep.equal({
+        types: [
+          {
+            name: "EmailTemplate",
+            members: ["unfiled$public"],
+          },
+        ],
+      });
+    });
+  });
+
   describe("#toString()", () => {
     it("should return the xml representation of a package", () => {
       const expectedXml = fs.readFileSync(path.resolve(__dirname, "fixtures", "package", "package.xml")).toString();