Add driver for MAX42500 #2659

kentlibe · 2024-12-01T23:05:34Z

PR Description

This adds new driver for the MAX42500 Industrial Power System Monitor Family, along with corresponding device tree bindings.
Datasheet MAX42500
Tested in RPI4 with MAX42500_EVKIT_P1.

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have tested the changes on the relevant hardware
I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa · 2024-12-02T10:11:39Z

Is this still WIP? As it stands it's not really ready for reviewing... Please make sure to address CI complains and to re-organize your commits. Merge commits don't really make sense (rebase your dev branch) and please run git lon --oneline <DIR_YOU'RE_CHANGING> so you can the git log style for that subsystem. Then, please follow the same style. Also note that a commit as Cleanup MAX42500 Linux driver. is not fine. You need to explain what you're actually cleaning and why...

Add documentation for devicetree bindings for MAX42500 Signed-off-by: Kent Libetario <[email protected]>

The MAX42500 is a SoC power-system monitor with up to seven voltage monitor inputs that will be SIL 3-Certified. Each input has programmable OV/UV thresholds of between 2.5% and 10% with ±1.3% accuracy over the full temperature range. Two of the inputs have a separate remote ground-sense input and support DVS through the integrated I2C interface. The MAX42500 contains a programmable flexible power sequence recorder (FPSR). This recorder stores power-up and power-down timestamps separately, and supports on/off and sleep/standby power sequences. The MAX42500 also contains a programmable challenge/response watchdog, which is accessible through the I2C interface, along with a configurable RESET output. Signed-off-by: Kent Libetario <[email protected]>

Add entry for the MAX42500 driver Signed-off-by: Kent Libetario <[email protected]>

kentlibe · 2024-12-17T05:45:36Z

v2

ready for review
address CI complaints
address style issues
re-organize commits
rebase dev branch

kister-jimenez

First review attempt.

I think you need to do some adjustments in you formatting especially the tabs to make the code more readable. I have commented some of them, but I see a lot needs to be adjusted.

kister-jimenez · 2024-12-20T08:14:44Z

Documentation/devicetree/bindings/hwmon/adi,max42500.yaml

+      - adi,max42500
+
+  reg:
+    description: I2C address of slave device.


No need for description for the I2C address.

kister-jimenez · 2024-12-20T08:15:28Z

Documentation/devicetree/bindings/hwmon/adi,max42500.yaml

+    minimum: 0x28
+    maximum: 0x2B


I don't think this is needed.

kister-jimenez · 2024-12-20T08:39:12Z

drivers/hwmon/max42500.c

+#define MAX42500_REG_CONFIG1			0x01
+#define MAX42500_REG_CONFIG2			0x02


You can add more tabs to align this.

kister-jimenez · 2024-12-20T08:39:25Z

drivers/hwmon/max42500.c

+#define MAX42500_REG_RSTMAP				0x04
+#define MAX42500_REG_STATOV				0x05
+#define MAX42500_REG_STATUV				0x06
+#define MAX42500_REG_STATOFF			0x07


you can add more tabs to align this.

kister-jimenez · 2024-12-20T08:39:46Z

drivers/hwmon/max42500.c

+#define MAX42500_REG_FPSSTAT1			0x16
+#define MAX42500_REG_FPSCFG1			0x17


you can add more tabs to align these.

kister-jimenez · 2024-12-20T09:03:57Z

drivers/hwmon/max42500.c

+ */
+static int max42500_set_nominal_voltage(struct max42500_state *st,
+										enum max42500_vm_input vm_in,
+										u8 voltage)


check your tabs

kister-jimenez · 2024-12-20T09:04:54Z

drivers/hwmon/max42500.c

+								MAX42500_REG_OVUV1 + vm_in,
+								GENMASK(7, 4),
+								FIELD_PREP(GENMASK(7, 4),
+								thresh));


check your tabs

kister-jimenez · 2024-12-20T09:05:30Z

drivers/hwmon/max42500.c

+ * @return 0 in case of success, negative error code otherwise.
+ */
+static int max42500_get_comp_status(struct max42500_state *st,
+									u8 vm_in, u8 *status)


check your tabs

kister-jimenez · 2024-12-20T09:05:49Z

drivers/hwmon/max42500.c

+	}
+
+	st->nominal_volt[vm_in] = voltage;
+	return max42500_reg_write(st, reg_addr, voltage);


add a new line before this return for better readability.

kister-jimenez · 2024-12-20T09:31:20Z

drivers/hwmon/max42500.c

+	HWMON_CHANNEL_INFO(chip,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY |
+			HWMON_C_TEMP_RESET_HISTORY | HWMON_C_POWER_RESET_HISTORY |
+			HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL | HWMON_C_ALARMS,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY,
+			HWMON_C_IN_RESET_HISTORY | HWMON_C_CURR_RESET_HISTORY),
+	HWMON_CHANNEL_INFO(in,
+			HWMON_I_LABEL | HWMON_I_INPUT | HWMON_I_LOWEST | HWMON_I_MIN |
+			HWMON_I_HIGHEST | HWMON_I_MAX,
+			HWMON_I_LABEL | HWMON_I_INPUT | HWMON_I_LOWEST | HWMON_I_MIN |
+			HWMON_I_HIGHEST | HWMON_I_MAX,
+			HWMON_I_LABEL | HWMON_I_INPUT | HWMON_I_LOWEST | HWMON_I_MIN,
+			HWMON_I_LABEL | HWMON_I_INPUT | HWMON_I_LOWEST | HWMON_I_MIN,
+			HWMON_I_LABEL | HWMON_I_INPUT | HWMON_I_LOWEST | HWMON_I_MIN,
+			HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL,
+			HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL,
+			HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL,
+			HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL, HWMON_I_LABEL),


can you double check the channels? I think there is a mismatch in the count.

kentlibe requested review from nunojsa, mhennerich, dbogdan, btogorean, chegbeli, buha, amiclaus, rbolboac, danmois, CiprianRegus and machschmitt as code owners December 1, 2024 23:05

kentlibe force-pushed the dev/max42500 branch 3 times, most recently from a3dad5b to a6008ba Compare December 10, 2024 07:49

kentlibe changed the title ~~Add driver support for MAX42500~~ Add driver for MAX42500 Dec 10, 2024

kentlibe force-pushed the dev/max42500 branch 2 times, most recently from de38b83 to 3f0942b Compare December 10, 2024 22:09

dt-bindings: hwmon: add adi,max42500.yaml

b55d79b

Add documentation for devicetree bindings for MAX42500 Signed-off-by: Kent Libetario <[email protected]>

kentlibe force-pushed the dev/max42500 branch from 3f0942b to 32dc5ba Compare December 10, 2024 23:02

kentlibe added 2 commits December 11, 2024 09:57

hwmon: Kconfig.adi: imply SENSORS_MAX42500

5920e35

Add entry for the MAX42500 driver Signed-off-by: Kent Libetario <[email protected]>

kentlibe force-pushed the dev/max42500 branch from 32dc5ba to 5920e35 Compare December 11, 2024 02:02

kister-jimenez suggested changes Dec 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add driver for MAX42500 #2659

Add driver for MAX42500 #2659

kentlibe commented Dec 1, 2024 •

edited

Loading

nunojsa commented Dec 2, 2024

kentlibe commented Dec 17, 2024

kister-jimenez left a comment

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

kister-jimenez Dec 20, 2024

		#define MAX42500_REG_CONFIG1 0x01
		#define MAX42500_REG_CONFIG2 0x02

		#define MAX42500_REG_FPSSTAT1 0x16
		#define MAX42500_REG_FPSCFG1 0x17

Add driver for MAX42500 #2659

Are you sure you want to change the base?

Add driver for MAX42500 #2659

Conversation

kentlibe commented Dec 1, 2024 • edited Loading

PR Description

PR Type

PR Checklist

nunojsa commented Dec 2, 2024

kentlibe commented Dec 17, 2024

kister-jimenez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kentlibe commented Dec 1, 2024 •

edited

Loading