Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for adm1273 #2675

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add support for adm1273 #2675

wants to merge 2 commits into from

Conversation

jemfgeronimo
Copy link

@jemfgeronimo jemfgeronimo commented Dec 11, 2024 •
edited
Loading

PR Description

The ADM1273 is also a Hot-swap controller similar to the ADM1272, with the
following differences:
* The MFR_MODEL register value is different.
* The ADM1273 includes the STATUS_CML register, which the ADM1272
does not have.

The currently available adm1275 driver supports the adm1272 and this patch
adds support for the adm1273. The ADM1273 is currently unreleased and the
datasheet is not yet publicly available.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@jemfgeronimo
dt-bindings: hwmon: adm1275: add adm1273
5d653c7 
Add support for the adm1273 Hot-Swap Controller and Digital Power
and Energy Monitor

Signed-off-by: John Erasmus Mari Geronimo <[email protected]>
@jemfgeronimo jemfgeronimo marked this pull request as ready for review December 11, 2024 06:02
nunojsa
nunojsa reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and send this upstream (I think commit messages could be improved though)

@jemfgeronimo
Copy link
Author

Already applied in hwmon staging tree
What should I do next?

@jemfgeronimo
hwmon: (pmbus/adm1275) add adm1273 support
de730ab 
Add support for adm1273 which is similar to adm1275 and other chips
of the series.

Signed-off-by: John Erasmus Mari Geronimo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunojsa nunojsa nunojsa left review comments

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@btogorean btogorean Awaiting requested review from btogorean btogorean is a code owner

@chegbeli chegbeli Awaiting requested review from chegbeli chegbeli is a code owner

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@machschmitt machschmitt Awaiting requested review from machschmitt machschmitt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jemfgeronimo @nunojsa