add ad3530r driver #2680
Open
add ad3530r driver #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseerp
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
kseerp
force-pushed
the
dev/ad353xr
branch
2 times, most recently
from
c22be05 to
69aa554
Compare
Add documentation for ad3530r. Signed-off-by: Kim Seer Paller <[email protected]>
The AD3530R/AD3530 are low power, 8-channel, 16-bit, buffered voltage output, DACs that include a 2.5V internal reference (disabled by default), and a gain bit field, resulting in a full-scale output span of 2.5V (gain = 1) or 5V (gain = 2) for a reference voltage of 2.5V. Signed-off-by: Kim Seer Paller <[email protected]>
Add entry for the AD3530R driver. Signed-off-by: Kim Seer Paller <[email protected]>
|
v2
|
nunojsa
reviewed
Jan 10, 2025
| #include <linux/module.h> | ||
| #include <linux/mod_devicetable.h> | ||
| #include <linux/mutex.h> | ||
| #include <linux/of.h> |
| return dev_err_probe(dev, ret, "Failed to get ref\n"); | ||
|
|
||
| st->vref_mv = st->range_multiplier ? 2 * ret / 1000 : ret / 1000; | ||
| } |
There was a problem hiding this comment.
It seems devm_regulator_get_enable_read_voltage() was backported to our tree. That will simplify the above block a lot.
| st = iio_priv(indio_dev); | ||
| st->spi = spi; | ||
|
|
||
| mutex_init(&st->lock); |
There was a problem hiding this comment.
devm_mutex_init() when upstreaming
| struct gpio_desc *reset_gpio; | ||
| int i, ret; | ||
|
|
||
| reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); |
There was a problem hiding this comment.
I guess you actually want GPIOD_OUT_HIGH
| "Failed to get reset GPIO\n"); | ||
|
|
||
| if (reset_gpio) { | ||
| /* Perfomr hardware reset */ |
| return ret; | ||
|
|
||
| return len; | ||
| case 4 ... 7: |
There was a problem hiding this comment.
Some macros would be nice
| st->chan[chan->channel].powerdown = powerdown; | ||
|
|
||
| switch (chan->channel) { | ||
| case 0 ... 3: |
| u8 ldac; | ||
| bool range_multiplier; | ||
|
|
||
| __be32 tx_buf __aligned(ARCH_DMA_MINALIGN); |
There was a problem hiding this comment.
this should be IIO_DMA_MINALIGN
| char *buf) | ||
| { | ||
| struct ad3530r_state *st = iio_priv(indio_dev); | ||
|
|
There was a problem hiding this comment.
for correctness, you should also guard() your access in here
| return ret; | ||
|
|
||
| guard(mutex)(&st->lock); | ||
| st->chan[chan->channel].powerdown = powerdown; |
There was a problem hiding this comment.
This should only be set after a successful cal to ad3530r_reg_update_bits()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Part is unreleased, allowed by requestor to create PR for public release and initial review.
PR Type
PR Checklist