-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make xls spreadsheet included via composer #137
Make xls spreadsheet included via composer #137
Conversation
xls.php - include vendor/autoload.php xls.php - left align plot xls.php - add test if imdbID field is blank to stop corrupt xls file amend config.sample.php
…ample.php (thus config.inc.php). this means that if user customizes the contains of data to spreadsheet, it will not be lost when refreshing version of videodb.
@copperhead57 could you remove all changes in the vendor folder from this pull request? so that i can merge this with only the changes from composer.json, config.sample, core/xls and xls.inc (and after that merge all remaining PRs) And what are your thoughts on merging all configuration options from xls.inc.php (and pdf.inc.php also) into the config.sample? I think that any 'performanceboost' from putting unused options in a separate file aren't even measurable these days, and it makes it predictable on where to find configuration options that might need changes... |
@johanneskonst I am not exactly sure how to do vendor folder changes manually as I am only novice user of composer (my IDE tool does all the work). As for merging config into config.sample a good idea but I have found out that it causes a problem if the user doesn't update their config.inc file. Without some method to auto update their file i foresee issues being raised. this is not a show stopper just an observation, I have done a quick change to this piece of work with a work around. |
Ah, i'll cleanup vendor later then, i just want to clear the list of PR and issues so we can move forward. |
xls.php - include vendor/autoload.php
xls.php - left align plot
xls.php - add test if imdbID field is blank to stop corrupt xls file
amend config.sample.php