Fixing size handling #126
Open
Fixing size handling #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When images have different orientations (portrait / landscape) usualy the resizing to eg. 1200x1200 the long side should fit into this values and the short side should be resized according to fit aspectRatio. Actually the task ignores images, when one side of the original image is smaller, than the according sizeTo-value. e.g. the original image is 1500x500 and it should fit into 1200x1200 actually the task generates an image with 1500x500 instead of 1200x400. This Bug is fixed with this changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When images have different orientations (portrait / landscape) usualy the resizing to eg. 1200x1200 the long side should fit into this values and the short side should be resized according to fit aspectRatio.
Actually the task ignores images, when one side of the original image is smaller, than the according sizeTo-value.
e.g. the original image is 1500x500 and it should fit into 1200x1200 actually the task generates an image with 1500x500 instead of 1200x400.
This Bug is fixed with this changes.