-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Change: Version 8.0.0 #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deComponent in multipart.
andrewlalis
changed the title
Breaking Change: Use MultiValueMap instead of associative arrays for request headers and query params
Breaking Change: Version 8.0.0
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this update, I am refactoring the
HttpRequest
'sheaders
andqueryParams
to use a newly-introducedMultiValueMap
type instead of associative arrays or arrays ofQueryParam
. This is inspired by Vibe's DictionaryList, and should help to make these properties easier to work with.I'm also incorporating lots of other small improvements to the API to make it more intuitive.
Here's a list of changes as I accumulate them:
HttpRequest
HttpRequest.headers
is now aStringMultiValueMap
.HttpRequest.queryParams
is now aStringMultiValueMap
.HttpRequest.params
associative array of query params.HttpRequest.hasHeader(string)
andHttpRequest.getHeader(string)
.handy_httpd.components.multipart
inHttpRequest
to provide immediate access toreadBodyAsMultipartFormData
as an additional way to read the request body.HttpRequestContext
req
andresp
toHttpRequestContext
to refer to therequest
andresponse
, respectively.Handlers
PathDelegatingHandler
. Only thePathHandler
is supported from now on.Worker Pool
RequestWorkerPool
interface, and added previous implementation asLegacyWorkerPool
, as well as aTaskPoolWorkerPool
based on std.parallelism.Configuration
ServerConfig.enableWebSockets
default tofalse
instead oftrue
.Examples