Refactored types in frame to use size_t (#fix 34) #35
Conversation
| private size_t readPayloadLength(S)(ubyte initialLength, S stream) if (isByteInputStream!S) { | ||
| if (initialLength == 126) { | ||
| return readDataOrThrow!(ushort)(stream); | ||
| } else if (initialLength == 127) { | ||
| return readDataOrThrow!(ulong)(stream); | ||
| return readDataOrThrow!(size_t)(stream); |
There was a problem hiding this comment.
The specification requires that the payload length be encoded as 64 bits if the initial length is 127, so it's gotta stay as readDataOrThrow!(ulong)(stream). I guess the best thing to do would be return cast(size_t) readDataOrThrow!(ulong)(stream);
There was a problem hiding this comment.
you are right, the frame length could be 64bit, but if I use ulong in 32 arm the compiler complains. I could do a cast from ulong to uint, but if actually the package is bigger than uint it generates a conversion error.... I have to think more about it. Thanks for the great support
|
Regarding your question about line 124, the |
|
Also, referencing #34 so that GitHub knows the issue is linked to this pr. |
|
Closing this because I implemented your changes, plus the details I mentioned in commit 4a22ed4 |
It compiles to ARM, but
I have a doubt about line 124.
perhaps it should be changed to
cast(size_t)?