Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Dropshots and edge-to-edge tests #1459

Draft
wants to merge 80 commits into
base: main
Choose a base branch
from
Draft

Adds Dropshots and edge-to-edge tests #1459

wants to merge 80 commits into from
+547 −9

Conversation

JoseAlcerreca
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch 2 times, most recently from 1adb04a to a14b142 Compare May 24, 2024 13:11
@android android deleted a comment from github-actions bot May 24, 2024
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.75% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.78% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.74% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.74% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch from 3469045 to dac5b22 Compare May 27, 2024 12:45
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.78% ❌

There is no coverage information present for the Files changed

@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch from 98f8c0c to a6a15ef Compare May 27, 2024 13:59
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.78% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.75% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.81% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

1 similar comment
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 39.77% ❌

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.41% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.38% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.37% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

2 similar comments
@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Combined test coverage report

Overall Project 41.37% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@JoseAlcerreca
Weird emulator issues, joy
96dd9dc 
Change-Id: Ie042a4ff74185279c4b42016261ce94757a5bee9
@JoseAlcerreca
Trying again with two emulator steps
175bb21
@JoseAlcerreca
Trying again with two emulator steps
b4f9e0d
@JoseAlcerreca
Debug hell
39c1bb4
@JoseAlcerreca
Debug hell
dee3bdb
@JoseAlcerreca
Debug hell
f8f80e8
@JoseAlcerreca
Debug hell
b2ad870
@JoseAlcerreca
Debug hell
d16ed17
@JoseAlcerreca
Runner hangs when launching emulator for the second time, trying new …
2b28127 
…memory args
@JoseAlcerreca
SHAME! I added an infinite loop
19edb84 
Change-Id: I60a019523ff703dfdda3ea0c16b052525412eb8d
@JoseAlcerreca
Fixed! Except for API 35, uploading logcat
2323822 
Change-Id: I689a9a6b1204df6c297704b6214a7ebb280d2d57
@JoseAlcerreca
Cutout tests, working locally. Need to rebase
e26492a 
Change-Id: Ib3e4dc2c62bbdd89bfd6380a33310e3033a58966
@JoseAlcerreca
Some more sync points, api 35 emulator crashing
0191ba0 
Change-Id: I90422a13aaba689b035095307446d7d343a59aed
@JoseAlcerreca JoseAlcerreca force-pushed the ja/edge-to-edge-dropshots branch from 7bfaf82 to 0191ba0 Compare June 6, 2024 13:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Combined test coverage report

Overall Project 41.4% 🍏

There is no coverage information present for the Files changed

@JoseAlcerreca
Copy link
Contributor Author

Update: Works pretty well although synchronization is done in a hacky way, possibly. Looking into better ways to do it.

Also, VanillaIceCream emulator is simply crashing and the step is not failing for some reason.

@keyboardsurfer
Copy link
Member

Thanks for your PR. Currently there are conflicts that need to be resolved before we can move on to possibly accepting your contribution. Please resolve the conflicts.

@JoseAlcerreca
Merge remote-tracking branch 'github/main' into ja/edge-to-edge-drops…
518555d 
…hots

Change-Id: If9ac392cc7a31f528e0d18b721d6dfba969a5e94
@JoseAlcerreca
Adds more sync to EdgeToEdgeTests
00f68b1 
Change-Id: I592e5fb2ee460c69ec88db414f21bdc00e27c15f
@JoseAlcerreca
Removes hardcoded version of cmdline-tools
e9c8033 
Change-Id: I7d5bbaeef396ebd425137ad03419efe26ccf6a4b
@JoseAlcerreca
VanillaIceCream -> 35
3afbfa4 
Change-Id: I66f493a050bd0d4fad80f22a7817adeb7124af45
@JoseAlcerreca
CI
16464b0 
Change-Id: I7e638265ebc58132efe04a37efd27393a2545446
@JoseAlcerreca
Change emulator build to 35.4.5 and spotless
6fe0bcd 
Change-Id: I0d18e6554667a32609512246fe84079b99aed2fc
@JoseAlcerreca
Change emulator build to 35.4.5
0b10aa7 
Change-Id: Ic6321f50c5303412914377f757201885a1a2e76d
@JoseAlcerreca
Adds emulator control to CI gradle properties
ec53bdd 
Change-Id: Ie66194bb50b81e3445627b973a2d1331f4a22dd3
@JoseAlcerreca
Copy link
Contributor Author

Current issue:

com.google.samples.apps.nowinandroid.ui.EdgeToEdgeTest > edgeToEdge_Foldable_api35[emulator-5554 - 15] FAILED 
	androidx.test.espresso.device.controller.DeviceControllerOperationException: Unable to connect to Emulator gRPC port. Please make sure the Android Emulator version is updated to 33.1.11+ and the controller gRPC service is enabled on the emulator. See https://developer.android.com/studio/preview/features#set_up_your_project_for_the_espresso_device_api for set up instructions.
	at

gradle.properties and build.gradle.kts seem correct

@JoseAlcerreca
Enables emulatorControl from convention plugins
9c101f2 
Change-Id: I2d544e9605b7c24eb8cf6528425bd95ab9b1e51f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaehwa-Noh Jaehwa-Noh Jaehwa-Noh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoseAlcerreca @keyboardsurfer @Jaehwa-Noh