Create a general error handler which handles multiple errors - Nia 1435 #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with MessageData Model
Including offline mesage in snackbar-bound state messages
Fake Error Monitor as EmptyErrorMonitor, containing no messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1435
Data layer General Message Handler Interface and Implementation, with Sealed Type Definitions.
Messages are extensible to both simple error messages and those with success/failure callbacks, so it can be used to handle both #1068 as well as any uses of
snackbarHostState.showSnackbar(), such as for theBookmark Saved Notification.Multiple message sources combined in NiaAppState, which will be a single source of truth for user bound messages via the Snackbar per this conversation
Display values defined by UI via
getSnackbarValueshelper in NiaAppFake ErrorMonitor implemented as EmptyErrorMonitor to remove conflicting with other tests.