Generate test vectors for batched txs. #4217
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4217 +/- ##
==========================================
- Coverage 74.54% 74.47% -0.07%
==========================================
Files 341 341
Lines 107549 107710 +161
==========================================
+ Hits 80173 80220 +47
- Misses 27376 27490 +114 ☔ View full report in Codecov by Sentry. |
murisi
force-pushed
the
murisi/batch-tx-testvectors
branch
from
6eb8611 to
625b600
Compare
grarco
approved these changes
Jan 7, 2025
|
A small comment, we can probably remove this FIXME that I had left back when we introduced batched transactions namada/crates/sdk/src/signing.rs Line 1069 in 9527ea9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Expanded the test vector generator to generate variable-length batch transactions. This is necessary as a step towards achieving hardware wallet batch transaction (printing and signing) support. See attached the test vectors (which show what the hardware wallet will be required to display) resulting from this change: batched_debugs.txt.gz batched_testvectors.json . This PR should not be merged before hardware wallet batch transaction support is implemented because that would cause the hardware wallet CI tests in this Namada repository to fail. Note: this draft PR was used to generate the following issue: Zondax/ledger-namada#97 .
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo