Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (b579d49), #4135, #4209, #4213 and [#4219 + #4220] together #4222

Closed
wants to merge 23 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2025

🎉 This combination of pull requests has been checked successfully and will be merged soon. 🎉

Branch main (b579d49), #4135, #4209, #4213 and [#4219 + #4220] are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of [#4219 + #4220].
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (2)
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-integration
    • check-neutral = test-integration
    • check-skipped = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 4219
  - number: 4220
...

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 46.31902% with 175 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (b579d49) to head (5cc1b1a).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/migrations.rs 32.20% 80 Missing ⚠️
crates/storage/src/mockdb.rs 0.00% 62 Missing ⚠️
crates/node/src/storage/rocksdb.rs 67.07% 27 Missing ⚠️
crates/governance/src/vp/mod.rs 0.00% 3 Missing ⚠️
crates/node/src/lib.rs 0.00% 2 Missing ⚠️
crates/node/src/shell/mod.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4222      +/-   ##
==========================================
- Coverage   74.62%   74.59%   -0.04%     
==========================================
  Files         342      342              
  Lines      108554   108724     +170     
==========================================
+ Hits        81009    81102      +93     
- Misses      27545    27622      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot closed this Jan 7, 2025
@mergify mergify bot deleted the mergify/merge-queue/53e9b9d954 branch January 7, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants