-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow which automatically adds backport tags based upon changelogs #2454
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 20s |
I did something similar here anyway I will close mine. |
Sure, if you've got any comments on the "how" behind this PR I'd appreciate a cursory review here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the release process guideline by adding the action to update this file?
Yup, will do. @abikouo would like the action moved over into the shared repo. Which I'll do first and should also simplify this file down. |
60a64e0
to
c8620d4
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 24s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 26s |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
…gelogs (ansible-collections#2454) ##### SUMMARY As has been recently noticed, we're being inconsistent with backporting things. Based on the keys from the changelog fragments this action would perform the following actions: - On "push" or applying the `mergeit` label - If a PR contains **non-backportable** changes (`major_changes`, `breaking_changes`, `removed_features`) the `do_not_backport` label will be applied. These change types are assumed to require a "major" release, and as such shouldn't be backported into a currently "stable" release. At the same time it will remove any previously applied `backport-*` labels. - When the "mergeit" label is applied: - If a PR contains changes that only need a **minor release** (minor_changes, deprecated_features) the `backport-9` label will be applied. - If a PR contains changes that only need a **patch release**, such as security/bug fixes (bugfixes, security_fixes), then `backport-8` and `backport-9` labels will both be applied. ##### ISSUE TYPE - Feature Pull Request ##### COMPONENT NAME .github/workflows ##### ADDITIONAL INFORMATION
…gelogs (ansible-collections#2454) ##### SUMMARY As has been recently noticed, we're being inconsistent with backporting things. Based on the keys from the changelog fragments this action would perform the following actions: - On "push" or applying the `mergeit` label - If a PR contains **non-backportable** changes (`major_changes`, `breaking_changes`, `removed_features`) the `do_not_backport` label will be applied. These change types are assumed to require a "major" release, and as such shouldn't be backported into a currently "stable" release. At the same time it will remove any previously applied `backport-*` labels. - When the "mergeit" label is applied: - If a PR contains changes that only need a **minor release** (minor_changes, deprecated_features) the `backport-9` label will be applied. - If a PR contains changes that only need a **patch release**, such as security/bug fixes (bugfixes, security_fixes), then `backport-8` and `backport-9` labels will both be applied. ##### ISSUE TYPE - Feature Pull Request ##### COMPONENT NAME .github/workflows ##### ADDITIONAL INFORMATION
SUMMARY
As has been recently noticed, we're being inconsistent with backporting things.
Based on the keys from the changelog fragments this action would perform the following actions:
mergeit
labelmajor_changes
,breaking_changes
,removed_features
) thedo_not_backport
label will be applied. These change types are assumed to require a "major" release, and as such shouldn't be backported into a currently "stable" release. At the same time it will remove any previously appliedbackport-*
labels.backport-9
label will be applied.backport-8
andbackport-9
labels will both be applied.ISSUE TYPE
COMPONENT NAME
.github/workflows
ADDITIONAL INFORMATION
tremble/amazon.aws currently has this workflow applied to it, if you want to test it out. (tremble#11 is the PR I've been testing with, but feel free to open your own PR and play with the labels against my fork.